fix(rpc): windows #6721
Merged
fix(rpc): windows #6721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use the pipe trick to interrupt the accept loop. This needs the pipe to be non blocking, but non blocking pipes are emulated on windows so we shouldn't try to set them to non blocking. Signed-off-by: Rudi Grinberg <me@rgrinberg.com> ps-id: 2dac6f72-88da-4456-97ac-0c55e080a10a
rgrinberg
force-pushed
the
ps/rr/fix_rpc___windows
branch
from
bc25fe2
to
870db70
Compare
jonahbeckford
approved these changes
Dec 18, 2022
emillon
pushed a commit
to emillon/dune
that referenced
this pull request
Dec 20, 2022
We use the pipe trick to interrupt the accept loop. This needs the pipe to be non blocking, but non blocking pipes are emulated on windows so we shouldn't try to set them to non blocking. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
emillon
pushed a commit
to emillon/dune
that referenced
this pull request
Dec 20, 2022
We use the pipe trick to interrupt the accept loop. This needs the pipe to be non blocking, but non blocking pipes are emulated on windows so we shouldn't try to set them to non blocking. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
emillon
added a commit
that referenced
this pull request
Dec 20, 2022
We use the pipe trick to interrupt the accept loop. This needs the pipe to be non blocking, but non blocking pipes are emulated on windows so we shouldn't try to set them to non blocking. Signed-off-by: Rudi Grinberg <me@rgrinberg.com> Signed-off-by: Rudi Grinberg <me@rgrinberg.com> Co-authored-by: Rudi Grinberg <me@rgrinberg.com>
emillon
added a commit
to emillon/opam-repository
that referenced
this pull request
Dec 21, 2022
…ne-site, dune-rpc, dune-rpc-lwt, dune-private-libs, dune-glob, dune-configurator, dune-build-info, dune-action-plugin and chrome-trace (3.6.2) CHANGES: - Fix configurator when using the MSVC compiler (ocaml/dune#6538, fixes ocaml/dune#6537, @nojb) - Fix running the RPC server on windows (ocaml/dune#6721 fixes ocaml/dune#6720, @rgrinberg)
jonahbeckford
pushed a commit
to diskuv/diskuv-opam-repository
that referenced
this pull request
Dec 23, 2022
…ne-site, dune-rpc, dune-rpc-lwt, dune-private-libs, dune-glob, dune-configurator, dune-build-info, dune-action-plugin and chrome-trace (3.6.2) CHANGES: - Fix configurator when using the MSVC compiler (ocaml/dune#6538, fixes ocaml/dune#6537, @nojb) - Fix running the RPC server on windows (ocaml/dune#6721 fixes ocaml/dune#6720, @rgrinberg)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the pipe trick to interrupt the accept loop. This needs the pipe
to be non blocking, but non blocking pipes are emulated on windows so we
shouldn't try to set them to non blocking.
Signed-off-by: Rudi Grinberg me@rgrinberg.com
ps-id: 2dac6f72-88da-4456-97ac-0c55e080a10a