Support multiple arguments with -Wl, #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 26, 2020
Up to this point, it just about worked concatenating the files together, although Buffer.to_bytes was technically included in several versions which already had it. Instead, have a single compatibility layer and filter out the lines which aren't needed using sed. This permits a single module to contain definitions from multiple different versions of the compiler. In passing, eliminated the deprecation warnings in 4.02 by using String.init instead of String.map
dra27
force-pushed
the
split-wl
branch
2 times, most recently
from
70b4f0a
to
3460d7a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #73 (comment).
The implementation is straightforward, but the compatibility layer still needs tweaking. Posting this is a draft to keep the issue alive.