-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conf-gmp build fails on NetBSD #18128
Comments
I would like to particularly encourage the use of pkg-config approach with this package instead of hardcoding |
The reason was that gmp didn't ship with its pkg-config file before 6.2.0. For instance Debian 10 (the current stable) still ships gmp 6.1.x and will fail if only pkg-config is tried. I'll have a try at fixing this issue soon. |
Also, side-note since you're using NetBSD: |
Hello Kate, Please consider the following code: files/conf-gmp.opam
files/config/dune
files/config/discover.ml
I think that dune should attempt to build a private executable from test. I'm trying to figure out how to specify the build of an executable from C in dune, since the old approach that involves the use of |
Also, please allow me to ask, how would you populate the |
I'm failing to see the advantages here. This is more code to maintain for us for nothing and does not bring any improvements compared to our fix. Furthermore, this brings a lot of dependencies for essentially nothing. Dune-configurator is helpful for packages themselves, not at all for meta packages here to detect and install external dependencies (conf-* packages). Conf packages are here as a common base from which whatever packages can depend on and not have to maintain their own set of depexts, packages that do not depend on dune are amongst them. |
Ok. Let's see if those changes do work on that NetBSD box then. Is there a way to quickly test your changes? I don't see the conf-gmp.4 in the master branch yet, so I doubt I could easily pin. Would you possibly suggest another alternative? |
yes: |
Is there a way to do this through opam pin? |
I guess |
I'm not 100% sure what's the exact semantics of that command. I see that a new tmp repositary had appeared under the build user's |
Weird, I only see conf-gmp.1 in your git repository: https://github.com/kit-ty-kate/opam-repository/tree/master/packages/conf-gmp |
Also, looking at your solution, I'm not seeing an attempt to build gmp if it is already listed in pkg-config database. Are you sure this is the correct approach? What is the purpose of conf- packages in general? Is it to test the presence features, or just to verify a system-specific record their presence? |
correct, because this is not the purpose of the conf-* packages (see #18128 (comment)). The purpose of opam is not to be replacement for system package manager.
You're not looking at the right branch (see PR or command above) It's 3am here so I'm going to bed. I'll merge my PR tomorrow at some point unless something is wrong. Good night. |
Ok. Thank you!
Ok. |
This issue has been open 90 days with no activity. Consequently, it is being marked with the "stale" label. What this means is that the issue will be automatically closed in 30 days unless more comments are added or the "stale" label is removed. If you come across this issue in the future, you may also find it helpful to visit our forum at https://discuss.ocaml.org where queries related to OCaml package management are very welcome. |
Report
opam install conf-gmp fails as follows:
Analysis
Looking at the corresponding opam definitions:
It is rather plain that the author had decided to hardcode include paths, instead of using pkg-config. The pkg-config on this NetBSD host produces the following correct output:
Please fix the issue.
The text was updated successfully, but these errors were encountered: