Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] eqaf (0.5) #14413

Merged
merged 4 commits into from
Jul 4, 2019
Merged

Conversation

dinosaure
Copy link
Contributor

Constant-time equal function on string

CHANGES:

CHANGES:

- Delete `min` and use `<>` operator to compare length on `equal` function
- Implementation of `compare_{be,le}{,with_len}` function (@cfcs, @hannesm, @dinosaure)
- Test on `compare` function (@dinosaure)
- Unit test on `compare` (@dinosaure)
- Fuzz test on `compare` (@dinosaure)
- Documentation (@dinosaure, @cfcs)
@mseri
Copy link
Member

mseri commented Jul 2, 2019

For some reasons it is failing on Travis (and in the CI -- although it appears green) for all recent versions of ocaml (4.06, 4.07, 4.08) with

[ERROR] No solution for eqaf.0.5: The following dependencies couldn't be met:
          - eqaf → crowbar → xmldiff → xmlm < 1.3.0 → ocaml < 4.06.0
              base of this switch (use `--unlock-base' to force)

@dinosaure
Copy link
Contributor Author

Hmmhmm, indeed xmlm.1.2.0 requires < ocaml.4.06.0 and these deps appear with (with-test} flag because we want to compile with opam install -t eqaf. I can not reproduce it on my side where opam install -t eqaf wants to install only crowbar - I don't understand OPAM looks into crowbar's deps for testing ...

@mseri
Copy link
Member

mseri commented Jul 3, 2019

I have disabled the tests on ocaml >= 4.06.0 for now. I thought opam was fixed to avoid recursive test-dependencies installation (ping @rjbou)

@mseri
Copy link
Member

mseri commented Jul 4, 2019

@kit-ty-kate do you understand why opam on Travis is trying to install the test dependencies of the test dependencies even now that the tests are disabled?

@kit-ty-kate
Copy link
Member

@mseri yes, simply because the test dependencies are still listed and opam is trying to get them. There is no way of "disabling" tests in the sense. You can only disable actions (and you did)

@kit-ty-kate
Copy link
Member

The recursive test problem is described in ocaml-opam/opam-depext#121

@kit-ty-kate
Copy link
Member

It should be good now. The failures in Travis are somewhat irrelevant

@kit-ty-kate kit-ty-kate merged commit b315862 into ocaml:master Jul 4, 2019
@dinosaure
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants