-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new release] eqaf (0.5) #14413
[new release] eqaf (0.5) #14413
Conversation
CHANGES: - Delete `min` and use `<>` operator to compare length on `equal` function - Implementation of `compare_{be,le}{,with_len}` function (@cfcs, @hannesm, @dinosaure) - Test on `compare` function (@dinosaure) - Unit test on `compare` (@dinosaure) - Fuzz test on `compare` (@dinosaure) - Documentation (@dinosaure, @cfcs)
For some reasons it is failing on Travis (and in the CI -- although it appears green) for all recent versions of ocaml (4.06, 4.07, 4.08) with
|
Hmmhmm, indeed |
I have disabled the tests on ocaml |
@kit-ty-kate do you understand why opam on Travis is trying to install the test dependencies of the test dependencies even now that the tests are disabled? |
@mseri yes, simply because the test dependencies are still listed and opam is trying to get them. There is no way of "disabling" tests in the sense. You can only disable actions (and you did) |
The recursive test problem is described in ocaml-opam/opam-depext#121 |
It should be good now. The failures in Travis are somewhat irrelevant |
Thanks! |
Constant-time equal function on string
CHANGES:
min
and use<>
operator to compare length onequal
functioncompare_{be,le}{,with_len}
function (@cfcs, @hannesm, @dinosaure)compare
function (@dinosaure)compare
(@dinosaure)compare
(@dinosaure)