-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make every packages incompatible with conduit 3.0.0 (+ fix conf-llvm on fedora) #17428
Conversation
Commit: f616d94 Good to see you Madam. 🌩️ opam-lint errors f616d94
☀️ Installability check (+0)🌤️ 7 ignored non-opam files:
|
@@ -48,7 +48,7 @@ depopts: [ | |||
conflicts: [ | |||
"cohttp" {<= "0.15.0"} | |||
"cohttp" {>= "0.18.0"} | |||
"conduit" {< "0.6.0"} | |||
"conduit" {< "0.6.0" | >= "3.0.0"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"conduit" {< "0.6.0" | >= "3.0.0"} | |
"conduit" {< "0.6.0" } | |
"conduit" {>= "3.0.0"} |
@@ -41,7 +41,7 @@ depopts: [ | |||
conflicts: [ | |||
"cohttp" {<= "0.15.0"} | |||
"cohttp" {>= "0.18.0"} | |||
"conduit" {< "0.6.0"} | |||
"conduit" {< "0.6.0" | >= "3.0.0"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"conduit" {< "0.6.0" | >= "3.0.0"} | |
"conduit" {< "0.6.0" } | |
"conduit" {>= "3.0.0"} |
@@ -40,7 +40,7 @@ depopts: [ | |||
conflicts: [ | |||
"cohttp" {<= "0.15.0"} | |||
"cohttp" {>= "0.18.0"} | |||
"conduit" {< "0.6.0"} | |||
"conduit" {< "0.6.0" | >= "3.0.0"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"conduit" {< "0.6.0" | >= "3.0.0"} | |
"conduit" {< "0.6.0" } | |
"conduit" {>= "3.0.0"} |
@@ -40,7 +40,7 @@ depopts: [ | |||
conflicts: [ | |||
"cohttp" {<= "0.15.0"} | |||
"cohttp" {>= "0.18.0"} | |||
"conduit" {< "0.6.0"} | |||
"conduit" {< "0.6.0" | >= "3.0.0"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"conduit" {< "0.6.0" | >= "3.0.0"} | |
"conduit" {< "0.6.0" } | |
"conduit" {>= "3.0.0"} |
@@ -40,7 +40,7 @@ depopts: [ | |||
conflicts: [ | |||
"cohttp" {<= "0.15.0"} | |||
"cohttp" {>= "0.18.0"} | |||
"conduit" {< "0.6.0"} | |||
"conduit" {< "0.6.0" | >= "3.0.0"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"conduit" {< "0.6.0" | >= "3.0.0"} | |
"conduit" {< "0.6.0" } | |
"conduit" {>= "3.0.0"} |
@@ -40,7 +40,7 @@ depopts: [ | |||
conflicts: [ | |||
"cohttp" {<= "0.15.0"} | |||
"cohttp" {>= "0.18.0"} | |||
"conduit" {< "0.6.0"} | |||
"conduit" {< "0.6.0" | >= "3.0.0"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"conduit" {< "0.6.0" | >= "3.0.0"} | |
"conduit" {< "0.6.0" } | |
"conduit" {>= "3.0.0"} |
@@ -40,7 +40,7 @@ depopts: [ | |||
conflicts: [ | |||
"cohttp" {<= "0.15.0"} | |||
"cohttp" {>= "0.18.0"} | |||
"conduit" {< "0.6.0"} | |||
"conduit" {< "0.6.0" | >= "3.0.0"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"conduit" {< "0.6.0" | >= "3.0.0"} | |
"conduit" {< "0.6.0" } | |
"conduit" {>= "3.0.0"} |
@@ -40,7 +40,7 @@ depopts: [ | |||
conflicts: [ | |||
"cohttp" {<= "0.15.0"} | |||
"cohttp" {>= "0.18.0"} | |||
"conduit" {< "0.6.0"} | |||
"conduit" {< "0.6.0" | >= "3.0.0"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"conduit" {< "0.6.0" | >= "3.0.0"} | |
"conduit" {< "0.6.0" } | |
"conduit" {>= "3.0.0"} |
@@ -45,7 +45,7 @@ depopts: [ | |||
conflicts: [ | |||
"cohttp" {< "0.18.0"} | |||
"cohttp" {>= "0.19.0"} | |||
"conduit" {< "0.8.4"} | |||
"conduit" {< "0.8.4" | >= "3.0.0"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"conduit" {< "0.8.4" | >= "3.0.0"} | |
"conduit" {< "0.8.4" } | |
"conduit" {>= "3.0.0"} |
@@ -49,7 +49,7 @@ depopts: [ | |||
conflicts: [ | |||
"cohttp" {< "0.18.0"} | |||
"cohttp" {>= "0.19.0"} | |||
"conduit" {< "0.8.4"} | |||
"conduit" {< "0.8.4" | >= "3.0.0"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"conduit" {< "0.8.4" | >= "3.0.0"} | |
"conduit" {< "0.8.4" } | |
"conduit" {>= "3.0.0"} |
@@ -55,7 +55,7 @@ depopts: [ | |||
conflicts: [ | |||
"cohttp" {< "0.18.0"} | |||
"cohttp" {>= "0.19.0"} | |||
"conduit" {< "0.8.4"} | |||
"conduit" {< "0.8.4" | >= "3.0.0"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"conduit" {< "0.8.4" | >= "3.0.0"} | |
"conduit" {< "0.8.4" } | |
"conduit" {>= "3.0.0"} |
@@ -57,7 +57,7 @@ depopts: [ | |||
conflicts: [ | |||
"cohttp" {< "0.18.0"} | |||
"cohttp" {>= "0.19.0"} | |||
"conduit" {< "0.8.4"} | |||
"conduit" {< "0.8.4" | >= "3.0.0"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"conduit" {< "0.8.4" | >= "3.0.0"} | |
"conduit" {< "0.8.4" } | |
"conduit" {>= "3.0.0"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of these for the various git versions. I stop marking them, we can fix them using a sed call all at once
@@ -56,6 +56,7 @@ depopts: [ | |||
conflicts: [ | |||
"cohttp" {< "0.18.3"} | |||
"git" {< "1.7.0" | >= "1.8.0"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Independent of this PR: Shouldn’t this be split on two lines as well?
If I recall correctly we needed to split conflicts on multiple lines otherwise the constraints were not correctly interpreted. In this case we need to fix all of the conflicts sections |
mh, I don't recall something like that. Are you referring to conflicts with |
Maybe it is that, I could not find an issue or a PR where I had seen it. That is why I was asking. So it is an issue only with &? Then we can merge this |
Yeah it should be fine. There are many other packages with this pattern in opam-repository already as well. If this is really an issue we can change it later but it should be equivalent. Merging then. |
@@ -45,7 +45,7 @@ depopts: [ | |||
conflicts: [ | |||
"cohttp" {< "0.18.0"} | |||
"cohttp" {>= "0.19.0"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still cannot find the issue, I only found #15441 which is somewhat unrelated. But look at the two lines above (and the same kind of repeated constraints are in many other packages)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and the |
works fine
cc @mseri @dinosaure