Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] ppx_getenv (2.1) #17481

Merged
merged 2 commits into from
Oct 24, 2020

Conversation

kit-ty-kate
Copy link
Member

A sample syntax extension using OCaml's new extension points API

CHANGES:

CHANGES:

- Upgrade to ppxlib 0.18.0 (ocaml-ppx/ppx_getenv#8, @NathanReb)
@@ -0,0 +1,40 @@
# This file is generated by dune, edit dune-project instead
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird.. @NathanReb is that expected? Maybe it's my branch that has an issue, I'm using https://github.com/kit-ty-kate/dune-release/tree/custom (with a few of my recent PRs + a fix for it to compile with opam 2.1)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, mh unless dune-release is doing something with the comments I'm guessing this is an effect of the upcoming ocaml/opam#4302 that I'm using locally

@camelus
Copy link
Contributor

camelus commented Oct 23, 2020

Commit: a10a2ae

Good to see you Madam.

☀️ All lint checks passed a10a2ae
  • These packages passed lint tests: ppx_getenv.2.1

☀️ Installability check (+1)
  • new installable packages (1): ppx_getenv.2.1

@kit-ty-kate
Copy link
Member Author

All green

@kit-ty-kate kit-ty-kate merged commit 9ed7a84 into ocaml:master Oct 24, 2020
@kit-ty-kate kit-ty-kate deleted the release-ppx_getenv-2.1 branch October 24, 2020 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants