bls12-381-unix can use 0.18.0 #18359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some warnings appear with ctypes 0.17.1. There is a fix upstream (https://gitlab.com/dannywillems/ocaml-bls12-381/-/commit/50c2416b4e1ea12e7ab01c2529cf5d8d8a424998). 0.17.1 is still allowed in this version in case of already some users require 0.17.1. However, tezos uses ctypes 0.18.0 and require this version.
|
The commit/PR name doesn't seem to to the same thing as its implementation. Is that expected? |
Yes, I motivate it in my first message. |
|
oh sorry nevermind I was seeing the change inverted. Thanks! |
|
Commit: 4a71e83 @dannywillems has posted 35 contributions. ☀️ All lint checks passed 4a71e83
☀️ Installability check (+0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some warnings appear with ctypes 0.17.1 (see yallop/ocaml-ctypes#646 and yallop/ocaml-ctypes#638). There is a fix upstream in master for future releases (https://gitlab.com/dannywillems/ocaml-bls12-381/-/commit/50c2416b4e1ea12e7ab01c2529cf5d8d8a424998). 0.17.1 is still allowed in this version in case of already some users require 0.17.1. However, tezos uses ctypes 0.18.0 and require this version.