-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all unnecessary name and version fields #18455
Conversation
There was some reason for which |
Do you know why this funny failure?
|
Is it reproducible ? |
opam-repo-ci is calling It would be easier to do be doing the equivalent of |
I tried to use the API used by opam source on Sunday, however this is inside the opam-client library which is currently incompatible with opam-repo-ci due to its transitive dependency on extlib (extlib < 1.7.8 and base64 cannot be used in the same project) |
Is there any reason not to shell out to |
Commit: 3dcd52f Good to see you Madam. 🌩️ opam-lint errors 3dcd52f
☀️ Installability check (+0) |
issue opened in opam-repo-ci bugtracker, better continue the discussion there |
I like this in principle, but I don't think we should merge it until @mseri's comment in #18455 (comment) is figured out. We should have one consistent policy for opam-repo, and ensure that no tools such as dune error out because they behave differently without a |
The issue in lwt.4.2.0 and lwt.4.2.1 is with the sources themselves. Dune looks at the opam files in the source distribution as the primary source of a package's version (although cf. ocaml/dune#4457) which is what was wrong in #17185. The opam file from the repository (or, in general, the one opam used to determine what to do to build and install the package) is not directly available to the build, although in opam 2.1 the
Having removed these unnecessary fields, do we have issues/PRs open for linting to keep them removed? |
This is already in opam-repo-ci since ocurrent/opam-repo-ci#70 |
Then I think we should go on and merge |
I checked and this does not make opam rebuild any installed packages, so this change should be painless for users.