-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new release] dns, dns-stub, dns-certify, dns-mirage, dns-resolver, dns-client, dns-server, dns-tsig and dns-cli (5.0.0) #18504
Conversation
…ns-client, dns-server, dns-tsig and dns-cli (5.0.0) CHANGES: * IPv6 support for client and server (Mirage, Unix, Lwt) (mirage/ocaml-dns#249 mirage/ocaml-dns#252 @hannesm) This results in breaking changes, especially in the Mirage boilerplate, since now a Mirage_stack.V4V6 is needed instead of a Mirage_stack.V4. * dns-certify: support EC private keys, now that X509 0.12.0 supports them (mirage/ocaml-dns#252 @hannesm)
//cc @dinosaure |
The failures on OCaml 4.13 are due to a bug in the type-checker: ocaml/ocaml#10271 so it can be ignored |
failures:
|
Commit: 9470681 A pull request by opam-seasoned @hannesm. ☀️ All lint checks passed 9470681
☀️ Installability check (+9)
|
I looked through the CI failures, and they are unrelated. This is good to be merged. |
Note sure why the builds on |
Thanks @talex5. I pushed a commit to restrict "resp-mirage" to conduit-mirage <2.3.0 to fix a CI issue that @kit-ty-kate was curious about. |
9866f03
to
844da50
Compare
looks like resp-mirage 0.10.0 is still in a non-working state. I doubt the root cause is a release of dns, and don't have the motivation to investigate further. what can I do to get this PR merged? |
844da50
to
9470681
Compare
I force-pushed a fix for resp-mirage -- it requires conduit-mirage 2.3.0 or later (not below, and not above 2.0.0). now CI has various other temporary issues. |
Looks fine, the remaining jobs are all timing out (which is not surprising imho given the amount of things this PR is testing). I think this can be merged |
Thanks! |
thanks! |
An opinionated Domain Name System (DNS) library
CHANGES:
This results in breaking changes, especially in the Mirage boilerplate,
since now a Mirage_stack.V4V6 is needed instead of a Mirage_stack.V4.
(API updates mirage/ocaml-dns#252 @hannesm)