[new release] alcotest, alcotest-async, alcotest-mirage and alcotest-lwt (1.4.0) #18509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 15, 2021
craigfe
force-pushed
the
release-alcotest-1.4.0
branch
from
7198de4 to
1089a8b
Compare
mseri
reviewed
Apr 15, 2021
|
Commit: 5ff3576 @craigfe has posted 37 contributions. 🌤️ opam-lint warnings 5ff3576
☀️ Installability check (+4)
|
|
There are quite a lot of timeouts in the rev-dep tests, but of the ones that actually ran I think I'm satisfied that none of the failures are due to this release. |
|
I went through all the errors (I believe). Most of the cancellations are actually successes. |
…lwt (1.4.0) CHANGES: - Add `?here` and `?pos` arguments to the test assertion functions. These can be used to pass information about the location of the call-site, which is displayed in failing test output. (mirage/alcotest#291, @craigfe) - Add a pretty-printer for the exception raised by `Alcotest.check` and related functions. This allows them to be used outside of an Alcotest test runner for making general assertions. (mirage/alcotest#296, @craigfe) - Add `--bail` option (and corresponding `ALCOTEST_BAIL` environment variable), which causes Alcotest to terminate after the first test failure. (mirage/alcotest#298, @craigfe)
Due to the breaking change to mutex semantics in this release.
Co-authored-by: Marcello Seri <mseri@users.noreply.github.com>
craigfe
force-pushed
the
release-alcotest-1.4.0
branch
from
71fb74f to
5ff3576
Compare
|
@mseri: thanks for picking those out. I've added the necessary bounds and made corresponding patches upstream. |
|
I went through all the failures once again. Again they are mostly all succeeded and the few failures have nothing to do with this PR. The tests waiting to run have already run (or timed out) on the previous run. I think we should release the pressure on the CI and merge. Thanks for the bounds and the fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alcotest is a lightweight and colourful test framework
CHANGES:
Add
?hereand?posarguments to the test assertion functions. These can beused to pass information about the location of the call-site, which is
displayed in failing test output. (Add optional location information on test assertion functions mirage/alcotest#291, @craigfe)
Add a pretty-printer for the exception raised by
Alcotest.checkand relatedfunctions. This allows them to be used outside of an Alcotest test runner for
making general assertions. (Register a printer for the Check_error exception mirage/alcotest#296, @craigfe)
Add
--bailoption (and correspondingALCOTEST_BAILenvironment variable),which causes Alcotest to terminate after the first test failure. (Add support for
--bailflag mirage/alcotest#298,@craigfe)