Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] eio_main, eio_luv, eio_linux and eio (0.1) #20695

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

talex5
Copy link
Contributor

@talex5 talex5 commented Feb 9, 2022

Effect-based direct-style IO mainloop for OCaml

CHANGES:
  • Initial release.

@talex5
Copy link
Contributor Author

talex5 commented Feb 9, 2022

Note the Unix.Unix_error(Unix.ENOMEM, "io_uring_register_buffers", "") error means that the CI worker decided not to let it lock enough memory. This often happens when the cluster is busy.

I see one of the tests wants to create a socket in /tmp, which fails because that's not mounted in CI. I'll change that upstream - does it need a new release?

The nnp test says:

  - downgrade ocaml-variants    4.13.1+options to 4.12.0+domains+effects

Is that expected?

@kit-ty-kate
Copy link
Member

Is that expected?

it’s not. I saw that some time ago (it’s only switching when it is not available, so it’s not a huge issue) but I was kind of hoping for ocaml/opam#5002 to be merged and backported a few weeks ago but obviously it wasn’t. I’ll try to hotfix opam-repo-ci but for now we can ignore them.

@kit-ty-kate
Copy link
Member

I see one of the tests wants to create a socket in /tmp, which fails because that's not mounted in CI. I'll change that upstream - does it need a new release?

if you can, that’d be much appreciated. /tmp is not available in the sandbox, you need to use $TMPDIR whenever available

@talex5
Copy link
Contributor Author

talex5 commented Feb 9, 2022

I think I might just disable the eio_main tests until we have the ENOMEM thing fixed. Otherwise, it'll generate lots of random failures in opam-health-check.

They are not reliable in CI because workers often give ENOMEM. Also,
they currently assume /tmp is writable.
@kit-ty-kate
Copy link
Member

Thanks!

@kit-ty-kate kit-ty-kate merged commit 6ed2f3a into ocaml:master Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants