Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x509 requires mirage-crypto-rng < 0.11.0 for tests #23238

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Feb 5, 2023

first part of #23237 revdeps

@hannesm
Copy link
Member Author

hannesm commented Feb 6, 2023

The CI failures are unrelated. I also do not plan to fix any further constraints in this PR. Please take a look at the diff to convince yourself that this is safe to merge. :)

@kit-ty-kate
Copy link
Member

The error was:

#=== ERROR while compiling x509.0.16.2 ========================================#
# context              2.2.0~alpha~dev | linux/x86_64 | ocaml-base-compiler.4.14.1 | file:///home/opam/opam-repository
# path                 ~/.opam/4.14/.opam-switch/build/x509.0.16.2
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune runtest -p x509 -j 255
# exit-code            1
# env-file             ~/.opam/log/x509-7-e7baf9.env
# output-file          ~/.opam/log/x509-7-e7baf9.out
### output ###
# (cd _build/default && /home/opam/.opam/4.14/bin/ocamlc.opt -w -40 -g -bin-annot -I tests/.tests.eobjs/byte -I /home/opam/.opam/4.14/lib/alcotest -I /home/opam/.opam/4.14/lib/alcotest/engine -I /home/opam/.opam/4.14/lib/alcotest/stdlib_ext -I /home/opam/.opam/4.14/lib/asn1-combinators -I /home/opam/.opam/4.14/lib/astring -I /home/opam/.opam/4.14/lib/base64 -I /home/opam/.opam/4.14/lib/cmdliner -I /home/opam/.opam/4.14/lib/cstruct -I /home/opam/.opam/4.14/lib/cstruct-unix -I /home/opam/.opam/4.14/lib/domain-name -I /home/opam/.opam/4.14/lib/eqaf -I /home/opam/.opam/4.14/lib/eqaf/bigstring -I /home/opam/.opam/4.14/lib/eqaf/cstruct -I /home/opam/.opam/4.14/lib/fmt -I /home/opam/.opam/4.14/lib/gmap -I /home/opam/.opam/4.14/lib/ipaddr -I /home/opam/.opam/4.14/lib/logs -I /home/opam/.opam/4.14/lib/macaddr -I /home/opam/.opam/4.14/lib/mirage-crypto -I /home/opam/.opam/4.14/lib/mirage-crypto-ec -I /home/opam/.opam/4.14/lib/mirage-crypto-pk -I /home/opam/.opam/4.14/lib/mirage-crypto-rng -I /home/opam/.opam/4.14/lib/mirage-crypto-rng/unix -I /home/opam/.opam/4.14/lib/pbkdf -I /home/opam/.opam/4.14/lib/ptime -I /home/opam/.opam/4.14/lib/ptime/clock/os -I /home/opam/.opam/4.14/lib/re -I /home/opam/.opam/4.14/lib/seq -I /home/opam/.opam/4.14/lib/sexplib0 -I /home/opam/.opam/4.14/lib/stdlib-shims -I /home/opam/.opam/4.14/lib/uutf -I /home/opam/.opam/4.14/lib/zarith -I lib/.x509.objs/public_cmi -no-alias-deps -o tests/.tests.eobjs/byte/tests.cmo -c -impl tests/tests.ml)
# File "tests/tests.ml", line 15, characters 36-38:
# 15 |   Mirage_crypto_rng_unix.initialize ();
#                                          ^^
# Error: This expression should not be a unit literal, the expected type is
#        'a Mirage_crypto_rng.generator

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants