Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

letsencrypt 0.2*, letsencrypt-app*: restrict to mirage-crypto-rng < 0.11.0 #23290

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Feb 10, 2023

The bin/oacmel uses Mirage_crypto_rng_unix.initialize, which API has been changed in mirage-crypto-rng 0.11.0 (spotted in #23282)

#=== ERROR while compiling letsencrypt.0.2.1 ==================================#
# context              2.2.0~alpha~dev | linux/x86_64 | ocaml-base-compiler.4.14.1 | file:///home/opam/opam-repository
# path                 ~/.opam/4.14/.opam-switch/build/letsencrypt.0.2.1
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p letsencrypt -j 255
# exit-code            1
# env-file             ~/.opam/log/letsencrypt-7-d83de3.env
# output-file          ~/.opam/log/letsencrypt-7-d83de3.out
### output ###
[...] (removed deprecation warnings)
# File "bin/oacmel.ml", line 22, characters 36-38:
# 22 |   Mirage_crypto_rng_unix.initialize () ;
#                                          ^^
# Error: This expression should not be a unit literal, the expected type is
#        'a Mirage_crypto_rng.generator
[...] (removed deprecation warnings)

@kit-ty-kate
Copy link
Member

Thanks

@kit-ty-kate kit-ty-kate merged commit d9e5d60 into ocaml:master Feb 10, 2023
@hannesm hannesm deleted the le-restrict-mirage-crypto-rng branch February 15, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants