[new release] opam-monorepo (0.3.6) #23745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGES: ### Added - Display warning when a package to be locked is missing a `dev-repo` field and is being skipped because of it (tarides/opam-monorepo#341, tarides/opam-monorepo#362, @kit-ty-kate, @Leonidas-from-XIV) - Add option `--keep-symlinked-dir` to preserve symlinks in `duniverse/`, which can be useful for local development. (tarides/opam-monorepo#348, tarides/opam-monorepo#366, @hannesm, @Leonidas-from-XIV) ### Changed - Canonicalize the URLs of the OPAM `dev-repo` fields to be able to detect more semantically equivalent URLs, this should reduce the risk of build failures due to duplicate code pulled (tarides/opam-monorepo#118, tarides/opam-monorepo#365 @TheLortex, @Leonidas-from-XIV) - Simple the error message printed when dependencies don't use dune as their build system. The opam-0install diagnostic message is no longer printed in this case and the message has been reformatted and reworded to make the salient information easier to see. (tarides/opam-monorepo#384, @gridbugs) ### Fixed - Error in case where multiple packages with different dev-repo fields would be placed in the same duniverse directory (tarides/opam-monorepo#377, @gridbugs) - Fix a failure when using opam-monorepo with an opam 2.2 root (tarides/opam-monorepo#379, @kit-ty-kate) - Fix assertion failure when prefix of "lock" subcommand is used (tarides/opam-monorepo#381, @gridbugs) - Treat packages without build commands as virtual only if also lack install commands, as some non-virtual packages might only have install commands. (tarides/opam-monorepo#376 @Leonidas-from-XIV, @gridbugs)
|
Looks good, the only failure seems more a known bug in ocaml 5.1 and should not block the merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assemble and manage fully vendored Dune repositories
CHANGES:
Added
dev-repofield andis being skipped because of it (What's the reasoning behind filtering packages that do not have a dev-repo field? tarides/opam-monorepo#341, Add warning when
dev-repois missing tarides/opam-monorepo#362, @kit-ty-kate, @Leonidas-from-XIV)--keep-symlinked-dirto preserve symlinks induniverse/, whichcan be useful for local development. (pull overwrites everything tarides/opam-monorepo#348, Preserve symlinks in
duniverse/if requested tarides/opam-monorepo#366, @hannesm,@Leonidas-from-XIV)
Changed
Canonicalize the URLs of the OPAM
dev-repofields to be able to detect moresemantically equivalent URLs, this should reduce the risk of build failures
due to duplicate code pulled (Semantically equivalent but different "dev-repo" fields lead to build errors tarides/opam-monorepo#118, Normalize Github URLs before comparing tarides/opam-monorepo#365 @TheLortex, @Leonidas-from-XIV)
Simple the error message printed when dependencies don't use dune as their
build system. The opam-0install diagnostic message is no longer printed in
this case and the message has been reformatted and reworded to make the
salient information easier to see. (Simplify error message when deps don't build with dune tarides/opam-monorepo#384, @gridbugs)
Fixed
Error in case where multiple packages with different dev-repo fields would be
placed in the same duniverse directory (Error when multiple dev-repos collide on dir tarides/opam-monorepo#377, @gridbugs)
Fix a failure when using opam-monorepo with an opam 2.2 root
(Fix a failure when using opam-monorepo with an opam 2.2 root tarides/opam-monorepo#379, @kit-ty-kate)
Fix assertion failure when prefix of "lock" subcommand is used (Fix crash when prefix of "lock" subcommand is used tarides/opam-monorepo#381,
@gridbugs)
Treat packages without build commands as virtual only if also lack install
commands, as some non-virtual packages might only have install commands.
(Mark packages as virtual when they have neither
buildnorinstalltarides/opam-monorepo#376 @Leonidas-from-XIV, @gridbugs)