-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new release] coq-lsp (0.1.7+8.18) #24440
[new release] coq-lsp (0.1.7+8.18) #24440
Conversation
This is pending on the merge of #24451 , I'm unsure what the procedure is when doing simultaneous releases. |
Usually, after we merge the dependent release, we restart the tests of the PR and review it |
The linked PR was closed, so we will wait for the next one (unless I have missed it) |
Thanks, I wanted to be sure I was following the right procedure. The new PR is incoming as soon as my own CI passes. I would be nice if dune-release could prepare simultaneous releases of packages that are not in the same repos, as a single opam repos PR. Would it be OK to implement that kind of workflow? |
New depending PR #24451 |
96fb7c7
to
3ee21d3
Compare
Pending PR merged, rebased this PR. |
CHANGES: ----------------------------- - New command line compiler `fcc`. `fcc` allows to access most features of `coq-lsp` without the need for a command line client, and it has been designed to be extensible and machine-friendly (@ejgallego, ejgallego/coq-lsp#507, fixes ejgallego/coq-lsp#472) - Enable web extension support. For now this will not try to start the coq-lsp worker as it is not yet built. (@ejgallego, ejgallego/coq-lsp#430, fixes ejgallego/coq-lsp#234) - Improvements and clenaups on hover display, in particular we don't print repeated `Notation` strings (@ejgallego, ejgallego/coq-lsp#422) - Don't fail on missing serlib plugins, they are indeed an optimization; this mostly impacts 8.16 by lowering the SerAPI requirements (@ejgallego, ejgallego/coq-lsp#421) - Fix bug that prevented "Goal after tactic" from working properly (@ejgallego, ejgallego/coq-lsp#438, reported by David Ilcinkas) - Fix "Error message browser becomes non-visible when there are many goals" by using a fixed-position separated error display (@TDiazT, ejgallego/coq-lsp#445, fixes ejgallego/coq-lsp#441) - Message about workspace detection was printing the wrong file, (@ejgallego, ejgallego/coq-lsp#444, reported by Alex Sanchez-Stern) - Display the list of pending obligations in info panel (@ejgallego, ejgallego/coq-lsp#262) - Preliminary support to display document performance data in panel (@ejgallego, ejgallego/coq-lsp#181) - Fix cases when workspace / root URIs are `null`, as per LSP spec, (ejgallego/coq-lsp#453 , reported by orilahav, fixes ejgallego/coq-lsp#283) - Pass implicit argument information to hover printer (@ejgallego, ejgallego/coq-lsp#453, fixes ejgallego/coq-lsp#448) - Fix keybinding for the "Show Goals at Point" command (@4ever2, ejgallego/coq-lsp#460) - Alert when `rootPath` is relative (ejgallego/coq-lsp#465, @ejgallego, report by Alex Sanchez-Stern) - Hook coq-lsp to ViZX extension (@bhaktishh, ejgallego/coq-lsp#469) - `proof/goals` request now takes an optional formatting parameter so clients can specify it per-request (@ejgallego, @bhaktishh, ejgallego/coq-lsp#470) - New command line argument `--idle-delay=$secs` that controls how much an idle server will sleep before going back to request processing. Default setting is `0.1`, using more aggressive settings like `0.01` can decrease latency of requests by ~4x (@ejgallego, @HazardousPeach, ejgallego/coq-lsp#467, ejgallego/coq-lsp#471) - Warnings from `_CoqProject` files are now applied (@ejgallego, reported by @arthuraa, ejgallego/coq-lsp#500) - Be more resilient when serializing unknowns Asts (@ejgallego, ejgallego/coq-lsp#503, reported by Gijs Pennings) - Coq's STM is not linked anymore to `coq-lsp` (@ejgallego, ejgallego/coq-lsp#511) - More granular options `send_perf_data` `send_diags`, `verbosity` will set them now (@ejgallego, ejgallego/coq-lsp#517) - Preliminary plugin API for completion events (@ejgallego, ejgallego/coq-lsp#518, fixes ejgallego/coq-lsp#506) - Limit the number of messages displayed in the goal window to 101, as to workaround slow render of Coq's pretty printing format. This is an issue for example in Search where we can get thousand of results. We also speed up the rendering a bit by not hashing twice, and fix a parameter-passing bug. (@ejgallego, ejgallego/coq-lsp#523, reported by Anton Podkopaev)
3ee21d3
to
26d2b05
Compare
CI is now good, sorry for the all the churn, and thanks for all your help folks. |
Thanks! |
Language Server Protocol native server for Coq
CHANGES:
fcc
.fcc
allows to access mostfeatures of
coq-lsp
without the need for a command line client,and it has been designed to be extensible and machine-friendly
(@ejgallego, [compiler] Flèche-based command line compiler. ejgallego/coq-lsp#507, fixes [meta] Standalone compiler ejgallego/coq-lsp#472)
the coq-lsp worker as it is not yet built. (@ejgallego, [code] Enable web extension support. ejgallego/coq-lsp#430, fixes
[code] Enable web extension ejgallego/coq-lsp#234)
print repeated
Notation
strings (@ejgallego, [hover] Refactoring and minor fixes. ejgallego/coq-lsp#422)optimization; this mostly impacts 8.16 by lowering the SerAPI
requirements (@ejgallego, [loader] Don't fail on missing serlib plugins ejgallego/coq-lsp#421)
(@ejgallego, [goals] Fix goals_after_tactic option retrieval. ejgallego/coq-lsp#438, reported by David Ilcinkas)
goals" by using a fixed-position separated error display (@TDiazT,
Progress indicator and comments don't interact correctly ejgallego/coq-lsp#445, fixes Error message browser becomes non-visible when there are many goals. ejgallego/coq-lsp#441)
(@ejgallego, [workspace] Fix message about workspace detection ejgallego/coq-lsp#444, reported by Alex Sanchez-Stern)
[info panel] Program Obligation support in infoview ejgallego/coq-lsp#262)
(@ejgallego, [code] [protocol] Add notification about document perf data. ejgallego/coq-lsp#181)
null
, as per LSP spec,([init] Be more resilient to input, fix bug on workspace parsing ejgallego/coq-lsp#453 , reported by orilahav, fixes [server] Initialize request doesn't handle properly the case where
workspaceFolders
isnull
. ejgallego/coq-lsp#283)fixes feature request: Hover should show implicit arguments ejgallego/coq-lsp#448)
rootPath
is relative ([lsp] [init] [workspace] Fix parsing of rootPath ejgallego/coq-lsp#465, @ejgallego, report by AlexSanchez-Stern)
proof/goals
request now takes an optional formatting parameterso clients can specify it per-request (@ejgallego, @bhaktishh, [protocol] Include goal output type in goals request ejgallego/coq-lsp#470)
--idle-delay=$secs
that controls howmuch an idle server will sleep before going back to request
processing. Default setting is
0.1
, using more aggressivesettings like
0.01
can decrease latency of requests by ~4x(@ejgallego, @HazardousPeach, Reduce thread delay in process queue for a speedup on short commands ejgallego/coq-lsp#467, [controller] [native] New parameter --idle-delay ejgallego/coq-lsp#471)
_CoqProject
files are now applied (@ejgallego,reported by @arthuraa, [workspace] Apply warning settings from _CoqProject ejgallego/coq-lsp#500)
reported by Gijs Pennings)
coq-lsp
(@ejgallego, [coq] Don't link the STM ejgallego/coq-lsp#511)send_perf_data
send_diags
,verbosity
will set them now (@ejgallego, [protocol] Rework verbosity into more granular options. ejgallego/coq-lsp#517)
fixes [controller] Registration for completed API ejgallego/coq-lsp#506)
as to workaround slow render of Coq's pretty printing format. This
is an issue for example in Search where we can get thousand of
results. We also speed up the rendering a bit by not hashing twice,
and fix a parameter-passing bug. (@ejgallego, [vscode] Limit the number of messages displayed in the goal window ejgallego/coq-lsp#523, reported by
Anton Podkopaev)