Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] ocamlformat-lib, ocamlformat and ocamlformat-rpc-lib (0.26.1) #24448

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

Julow
Copy link
Contributor

@Julow Julow commented Sep 15, 2023

Auto-formatter for OCaml code

CHANGES:

Changed

Fixed

….26.1)

CHANGES:

### Changed

- Compatible with OCaml 5.1.0 (ocaml-ppx/ocamlformat#2412, @Julow)
  The syntax of let-bindings changed sligthly in this version.
- Improved ocp-indent compatibility (ocaml-ppx/ocamlformat#2428, @Julow)
- \* Removed extra break in constructor declaration with comment (ocaml-ppx/ocamlformat#2429, @Julow)
- \* De-indent the `object` keyword in class types (ocaml-ppx/ocamlformat#2425, @Julow)
- \* Consistent formatting of arrows in class types (ocaml-ppx/ocamlformat#2422, @Julow)

### Fixed

- Fix dropped attributes on a begin-end in a match case (ocaml-ppx/ocamlformat#2421, @Julow)
- Fix dropped attributes on begin-end in an if-then-else branch (ocaml-ppx/ocamlformat#2436, @gpetiot)
- Fix non-stabilizing comments before a functor type argument (ocaml-ppx/ocamlformat#2420, @Julow)
- Fix crash caused by module types with nested `with module` (ocaml-ppx/ocamlformat#2419, @Julow)
- Fix ';;' formatting between doc-comments and toplevel directives (ocaml-ppx/ocamlformat#2432, @gpetiot)
@Julow
Copy link
Contributor Author

Julow commented Sep 18, 2023

How can I fix the CI failures ?

@mseri
Copy link
Member

mseri commented Sep 19, 2023

The failures are unrelated from this PR, they reliably appear in many builds. Ping @jonahbeckford

# /usr/bin/git --no-pager diff --no-index --color=always -u _build/default/runner/bin/validate_user.dlls.txt _build/default/runner/bin/validate_user.dlls.txt.corrected
# diff --git a/_build/default/runner/bin/validate_user.dlls.txt b/_build/default/runner/bin/validate_user.dlls.txt.corrected
# index 7d36be4..75f8c9f 100644
# --- a/_build/default/runner/bin/validate_user.dlls.txt
# +++ b/_build/default/runner/bin/validate_user.dlls.txt.corrected
# @@ -1,3 +1,3 @@
#  Used DLLs:
# -	dllcamlstr
# -	dllunix
# +	dllunixbyt
# +	dllcamlstrbyt
# File "runner/bin/validate_admin.dlls.txt", line 1, characters 0-0:
# /usr/bin/git --no-pager diff --no-index --color=always -u _build/default/runner/bin/validate_admin.dlls.txt _build/default/runner/bin/validate_admin.dlls.txt.corrected
# diff --git a/_build/default/runner/bin/validate_admin.dlls.txt b/_build/default/runner/bin/validate_admin.dlls.txt.corrected
# index 7d36be4..75f8c9f 100644
# --- a/_build/default/runner/bin/validate_admin.dlls.txt
# +++ b/_build/default/runner/bin/validate_admin.dlls.txt.corrected
# @@ -1,3 +1,3 @@
#  Used DLLs:
# -	dllcamlstr
# -	dllunix
# +	dllunixbyt
# +	dllcamlstrbyt

@mseri mseri merged commit 98bb73c into ocaml:master Sep 19, 2023
@mseri
Copy link
Member

mseri commented Sep 19, 2023

Thanks

@Julow
Copy link
Contributor Author

Julow commented Sep 19, 2023

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants