-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new release] lbfgs (0.9.5) #24571
[new release] lbfgs (0.9.5) #24571
Conversation
a6b45dd
to
2e8c94d
Compare
packages/lbfgs/lbfgs.0.9.5/opam
Outdated
tags: [ "science" "numerics" "optimization" "minimization" "maximization" | ||
"bound-constrained" "large-scale" ] | ||
build: [ | ||
["dune" "subst"] {pinned} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
["dune" "subst"] {pinned} | |
["dune" "subst"] {dev} |
This causes a linter warning. I believe if you use Dune >= 2.7 to make the publish, it should automatically use dev
instead of pin
for this clause.
ref: https://github.com/ocaml/dune/blob/main/CHANGES.md#270-13082020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
packages/lbfgs/lbfgs.0.9.5/opam
Outdated
opam-version: "2.0" | ||
maintainer: "Christophe Troestler <Christophe.Troestler@umons.ac.be>" | ||
authors: [ "Christophe Troestler <Christophe.Troestler@umons.ac.be>" ] | ||
license: "LGPL-3.0 with OCaml linking exception" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems that the previous license is LGPL-3.0-only WITH OCaml-LGPL-linking-exception
(which is slightly different than the one in this PR.) Is this change intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was "normalized" in this repository but not in mine. I've updated my repo.
The CI failures seem unrelated to this package and are not blockers. |
just fyi: @mmottl
|
CHANGES: - Compatibility with OCaml 5 (Edwin Török). - Fix bug allowing to use it in the toplevel (Edwin Török).
2e8c94d
to
2b7e9b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good to me now. CI failures are all unrelated.
Bound-constrainted optimization in many variables
CHANGES: