Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] lbfgs (0.9.5) #24571

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

Chris00
Copy link
Member

@Chris00 Chris00 commented Oct 3, 2023

Bound-constrainted optimization in many variables

CHANGES:
  • Compatibility with OCaml 5 (Edwin Török).
  • Fix bug allowing to use it in the toplevel (Edwin Török).

tags: [ "science" "numerics" "optimization" "minimization" "maximization"
"bound-constrained" "large-scale" ]
build: [
["dune" "subst"] {pinned}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
["dune" "subst"] {pinned}
["dune" "subst"] {dev}

This causes a linter warning. I believe if you use Dune >= 2.7 to make the publish, it should automatically use dev instead of pin for this clause.
ref: https://github.com/ocaml/dune/blob/main/CHANGES.md#270-13082020

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

opam-version: "2.0"
maintainer: "Christophe Troestler <Christophe.Troestler@umons.ac.be>"
authors: [ "Christophe Troestler <Christophe.Troestler@umons.ac.be>" ]
license: "LGPL-3.0 with OCaml linking exception"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems that the previous license is LGPL-3.0-only WITH OCaml-LGPL-linking-exception (which is slightly different than the one in this PR.) Is this change intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was "normalized" in this repository but not in mine. I've updated my repo.

@haochenx
Copy link
Collaborator

haochenx commented Oct 4, 2023

The CI failures seem unrelated to this package and are not blockers.

@haochenx
Copy link
Collaborator

haochenx commented Oct 4, 2023

just fyi: @mmottl
it seems that lacamel is failing to build on ppc64-ocaml-4.14 and you may want to have a look
image

The following actions will be performed:
=== install 2 packages
  - install lacaml 11.0.10        [required by lbfgs]
  - install lbfgs  0.9.5 (pinned)

<><> Processing actions <><><><><><><><><><><><><><><><><><><><><><><><><><><><>
Processing  1/6:
-> retrieved lacaml.11.0.10  (cached)
Processing  3/6: [lacaml: dune build]
+ /home/opam/.opam/opam-init/hooks/sandbox.sh "build" "dune" "build" "-p" "lacaml" "-j" "175" "@install" (CWD=/home/opam/.opam/4.14/.opam-switch/build/lacaml.11.0.10)
- File "src/config/dune", line 24, characters 35-57:
- 24 |     (names zdot_is_procedure_stubs zdot_is_function_stubs)
-                                         ^^^^^^^^^^^^^^^^^^^^^^
- (cd _build/default/src/config && /usr/bin/gcc -O2 -fno-strict-aliasing -fwrapv -pthread -fPIC -D_FILE_OFFSET_BITS=64 -O2 -fno-strict-aliasing -fwrapv -pthread -fPIC -DEXTERNAL_EXP10 -std=c99 -march=native -O3 -ffast-math -fPIC -DPIC -g -I /home/opam/.opam/4.14/lib/ocaml -o zdot_is_function_stubs.o -c zdot_is_function_stubs.c)
- gcc: error: unrecognized command-line option '-march=native'; did you mean '-mcpu=native'?
- File "src/config/dune", line 24, characters 11-34:
- 24 |     (names zdot_is_procedure_stubs zdot_is_function_stubs)
-                 ^^^^^^^^^^^^^^^^^^^^^^^
- (cd _build/default/src/config && /usr/bin/gcc -O2 -fno-strict-aliasing -fwrapv -pthread -fPIC -D_FILE_OFFSET_BITS=64 -O2 -fno-strict-aliasing -fwrapv -pthread -fPIC -DEXTERNAL_EXP10 -std=c99 -march=native -O3 -ffast-math -fPIC -DPIC -g -I /home/opam/.opam/4.14/lib/ocaml -o zdot_is_procedure_stubs.o -c zdot_is_procedure_stubs.c)
- gcc: error: unrecognized command-line option '-march=native'; did you mean '-mcpu=native'?

Chris00 added a commit to Chris00/L-BFGS-ocaml that referenced this pull request Oct 12, 2023
Chris00 added a commit to Chris00/L-BFGS-ocaml that referenced this pull request Oct 12, 2023
CHANGES:

- Compatibility with OCaml 5 (Edwin Török).
- Fix bug allowing to use it in the toplevel (Edwin Török).
Copy link
Collaborator

@haochenx haochenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me now. CI failures are all unrelated.

@raphael-proust raphael-proust merged commit 8151605 into ocaml:master Oct 18, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants