Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] reason (2 packages) (3.12.0) #26271

Merged
merged 3 commits into from
Jul 28, 2024

Conversation

anmonteiro
Copy link
Contributor

Reason: Syntax & Toolchain for OCaml

CHANGES:

CHANGES:

- Add `\u{hex-escape}` syntax (@anmonteiro,
  [reasonml/reason#2738](reasonml/reason#2738))
- Support local open and let bindings (@SanderSpies) [reasonml/reason#2716](reasonml/reason#2716)
- outcome printer: change the printing of `@bs.*` to `@mel.*` (@anmonteiro, [reasonml/reason#2755](reasonml/reason#2755))
- Fix outcome printing of optional arguments on OCaml 5.2 (@anmonteiro, [reasonml/reason#2753](reasonml/reason#2753))
- support parsing and printing of `external%extension` (@anmonteiro, [reasonml/reason#2750](reasonml/reason#2750), [reasonml/reason#2766](reasonml/reason#2766), [reasonml/reason#2767](reasonml/reason#2767))
- install `refmt` manpage (@anmonteiro, [reasonml/reason#2760](reasonml/reason#2760))
- add support for parsing / printing of refutation clause in `switch` (@anmonteiro, [reasonml/reason#2765](reasonml/reason#2765))
- support `let%ppx` in signatures (@anmonteiro, [reasonml/reason#2770](reasonml/reason#2770))
raphael-proust added a commit that referenced this pull request Jul 24, 2024
There is a failure in the CI of #26271 which seem to be related to server-reason-react.

When checking the revdeps `server-reason-react.0.3.0`, the following type mismatch happens.

```
# File "packages/melange.js/Js.ml", line 496, characters 44-73:
# 496 |   let fromString : string -> t = fun str -> Quickjs.RegExp.compile str ""
#                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
# Error: This expression has type
#          "(Quickjs.RegExp.t,
#           [ `Invalid_escape_sequence
#           | `Malformed_unicode_char
#           | `Nothing_to_repeat
#           | `Unexpected_end
#           | `Unknown of string ] * string)
#          Stdlib.result"
#        but an expression was expected of type "t" = "Quickjs.RegExp.t"
```

ping @davesnx
Co-authored-by: Raphaël Proust <raphael-proust@users.noreply.github.com>
@anmonteiro
Copy link
Contributor Author

@mseri thanks for bumping the ocaml constraint but I think we want to find a fix upstream to still support OCaml 4.03. I'll update our decision here in a few days.

@mseri
Copy link
Member

mseri commented Jul 26, 2024

As you prefer. I put a do not merge tag to avoid mistakes from our side.

If it can help, all the actively maintained linux distributions are shipping 4.08+ at this point

@anmonteiro
Copy link
Contributor Author

anmonteiro commented Jul 27, 2024

As you prefer. I put a do not merge tag to avoid mistakes from our side.

If it can help, all the actively maintained linux distributions are shipping 4.08+ at this point

that makes sense, let's go ahead and merge then. we can drop support for 4.03 / 4.04 / 4.05

@mseri
Copy link
Member

mseri commented Jul 28, 2024

Do you know if this error is related to the release?


#=== ERROR while compiling melange.4.0.0-52 ===================================#
# context              2.3.0~alpha~dev | linux/x86_64 | ocaml-base-compiler.5.2.0 | file:///home/opam/opam-repository
# path                 ~/.opam/5.2/.opam-switch/build/melange.4.0.0-52
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p melange -j 255 @install
# exit-code            1
# env-file             ~/.opam/log/melange-7-d0d2cb.env
# output-file          ~/.opam/log/melange-7-d0d2cb.out
### output ###
# (cd _build/default/jscomp/core && /usr/bin/bash -e -u -o pipefail -c 'echo let version = \"$(git rev-parse --verify HEAD)\"') > _build/default/jscomp/core/git_commit.ml
# fatal: not a git repository (or any parent up to mount point /)
# Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
# (cd _build/default/jscomp/core && /usr/bin/bash -e -u -o pipefail -c 'echo let short_version = \"$(git rev-parse --short HEAD)\"') > _build/default/jscomp/core/git_commit.ml
# fatal: not a git repository (or any parent up to mount point /)
# Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
# File "jscomp/others/.belt.objs/melange/_unknown_", line 1, characters 0-0:
# (cd _build/default && bin/melc.exe -w -40 -w -49 -nopervasives -nostdlib -g -bin-annot -bin-annot-occurrences -I jscomp/others/.belt.objs/melange --bs-stop-after-cmj --bs-package-output . --bs-module-name belt__ --bs-package-name melange.belt -no-alias-deps -o jscomp/others/.belt.objs/melange/belt__.cmj -c -impl jscomp/others/belt__.ml-gen)
# melc: unknown option '--bin-annot-occurrences'.
# Usage: melc [OPTION]… [filenames]…
# Try 'melc --help' for more information.
# File "jscomp/others/.dom.objs/melange/_unknown_", line 1, characters 0-0:
# (cd _build/default && bin/melc.exe -w -40 -w -49 -nopervasives -nostdlib -g -bin-annot -bin-annot-occurrences -I jscomp/others/.dom.objs/melange --bs-stop-after-cmj --bs-package-output . --bs-module-name dom__ --bs-package-name melange.dom -no-alias-deps -o jscomp/others/.dom.objs/melange/dom__.cmj -c -impl jscomp/others/dom__.ml-gen)
# melc: unknown option '--bin-annot-occurrences'.
# Usage: melc [OPTION]… [filenames]…
# Try 'melc --help' for more information.
# File "jscomp/runtime/.melange_mini_stdlib.objs/melange/_unknown_", line 1, characters 0-0:
# (cd _build/default && bin/melc.exe -w -40 -nostdlib -nopervasives -bin-annot -bin-annot-occurrences -I jscomp/runtime/.melange_mini_stdlib.objs/melange --bs-stop-after-cmj --bs-package-output . --bs-module-name melange_mini_stdlib --bs-package-name melange.__private__.melange_mini_stdlib -no-alias-deps -o jscomp/runtime/.melange_mini_stdlib.objs/melange/melange_mini_stdlib.cmj -c -impl jscomp/runtime/melange_mini_stdlib.pp.ml)
# melc: unknown option '--bin-annot-occurrences'.
# Usage: melc [OPTION]… [filenames]…
# Try 'melc --help' for more information.

@anmonteiro
Copy link
Contributor Author

@mseri that's not related to this release, and was fixed in Melange 4.0.1-52. we could likely even disable that release.

@anmonteiro
Copy link
Contributor Author

disabled in #26301

@mseri mseri merged commit e6ce5f6 into ocaml:master Jul 28, 2024
2 of 3 checks passed
@mseri
Copy link
Member

mseri commented Jul 28, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants