Make sure that recursive dependencies are not reflexive

ocaml · Aug 14, 2021 · 4e008f8 · 4e008f8
1 parent c8f8f74
commit 4e008f8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/master_changes.md b/master_changes.md
@@ -38,7 +38,7 @@ users)
   *
 
 ## List
-  *
+  * Do not list the package itself when running `--depends-on` and `--required-by` with `--required` [#4804 @LasseBlaauwbroek]
 
 ## Show
   *

diff --git a/src/client/opamListCommand.ml b/src/client/opamListCommand.ml
@@ -226,10 +226,11 @@ let apply_selector ~base st = function
       | Depends_on _ -> OpamSolver.reverse_dependencies
       | _ -> assert false
     in
-    deps_fun ~depopts:tog.depopts ~build:tog.build ~post:tog.post
+    let packages = packages_of_atoms st atoms in
+    let deps = deps_fun ~depopts:tog.depopts ~build:tog.build ~post:tog.post
       ~installed:false ~unavailable:true
-      (get_universe st tog)
-      (packages_of_atoms st atoms)
+      (get_universe st tog) packages in
+    OpamPackage.Set.diff deps packages
   | Required_by (tog, atoms) ->
     atom_dependencies st tog atoms |>
     OpamFormula.packages base