Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opam.2.1.0~beta2] opam install --update-invariant does not change the invariant #4353

Closed
kit-ty-kate opened this issue Sep 13, 2020 · 2 comments · Fixed by #4360
Closed

[opam.2.1.0~beta2] opam install --update-invariant does not change the invariant #4353

kit-ty-kate opened this issue Sep 13, 2020 · 2 comments · Fixed by #4360
Projects
Opam 2.1.x
Milestone
2.1.0~beta4

Comments

@kit-ty-kate
Copy link
Member

opam install --update-invariant does not seem to change the switch invariant as opposed to what the name is suggesting.
For instance:

$ opam switch invariant
["ocaml-variants" {= "4.11.0+trunk"}]
$ opam install --update-invariant ocaml-base-compiler.4.11.1
[...]
$ opam switch invariant
["ocaml-variants" {= "4.11.0+trunk"}]
@AltGr
Copy link
Member

AltGr commented Sep 14, 2020

ouch, that seems bad, I'll investigate. Thanks a lot for all the testing!

AltGr added a commit to OCamlPro/opam that referenced this issue Sep 15, 2020
@AltGr
Fix --update-invariant when changing package name
e23b712 
Fixes ocaml#4353, although an issue remains if invariant packages are purely
removed, as opposed to replaced.
AltGr added a commit to OCamlPro/opam that referenced this issue Sep 15, 2020
@AltGr
Fix --update-invariant when changing package name
1d59d02 
Fixes ocaml#4353, although an issue remains if invariant packages are purely
removed, as opposed to replaced.
@rjbou rjbou linked a pull request Sep 15, 2020 that will close this issue
Fix --update-invariant when removing or changing package name #4360
Merged
@rjbou rjbou added this to the 2.1.0~beta3 milestone Sep 15, 2020
@rjbou rjbou added this to To do in Opam 2.1.x via automation Sep 15, 2020
@rjbou rjbou moved this from To do to In Progress in Opam 2.1.x Sep 15, 2020
Opam 2.1.x automation moved this from In Progress to Done Sep 16, 2020
@brando90
Copy link

example of command use:

opam switch
opam switch create coq-8.4.6 4.07.1
eval $(opam env --switch=coq-8.4.6 --set-switch)
opam pin add -y coq 8.4.6
opam pin add --update-invariant -y coq 8.4.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Opam 2.1.x
  
Done
Milestone
2.1.0~beta4
Development

Successfully merging a pull request may close this issue.

Fix --update-invariant when removing or changing package name OCamlPro/opam
4 participants
@AltGr @brando90 @kit-ty-kate @rjbou