-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opam master can't run commands on ocaml < 4.08.0 and Xcode 12 #4448
Comments
In both case, it shouldn't error with a simple |
I'm afraid I have no idea how
Shouldn't that code use https://caml.inria.fr/pub/docs/manual-ocaml/libref/Unix.html#VALaccess instead? In C, |
Looking at 41d44f9 and ocaml/ocaml#7640, I see why you reimplement |
The ACL stuff shouldn’t be happening unless you’re on Cygwin - although it’s making me wonder if that’s strictly necessary there too, now (although I expect I would still have hit the same bug in Cygwin even using |
That part is fixed in #4449. The permission errors remain — printf debugging suggests that
AFAIK Darwin has its own ACLs, but I wasn't asking about Context:
|
Okay, ocaml 4.07.1's configure gives (after instrumenting)
|
The new title is tentative and is based on extrapolation — I've estimated the impact based on ocaml/opam-repository@3d6ee07. I can also confirm that adding Source patch (EDIT: now also Blaisorblade/ocaml@c4d1ba5). diff --git a/config/auto-aux/runtest b/config/auto-aux/runtest
index c889a0dbd..861598e65 100755
--- a/config/auto-aux/runtest
+++ b/config/auto-aux/runtest
@@ -15,7 +15,7 @@
#* *
#**************************************************************************
-cmd="$cc $cflags -o tst $* $ldflags $cclibs"
+cmd="$cc $cflags -Wno-implicit-function-declaration -o tst $* $ldflags $cclibs"
if $verbose; then
echo "runtest: $cmd" >&2 Effect on configure logs:
|
openssl invocation: Fix fallback (part of #4448)
FWIW: while the main issue is due to old OCaml versions, and the use of https://github.com/freebsd/freebsd/blob/c5a1b0313c98d82c7d73ace37d69cee697f25cbf/usr.bin/which/which.c#L105-L121 (there's a workaround for |
dev meeting 26/2/21: @Blaisorblade how important is support for OCaml <4.08 to you for compiling the opam binary? We are going to make 4.08 the minimum supported version for compiling opam 2.1.0 onwards. Note that there is a |
(woops, that was @avsm above in the wrong Firefox container ;-) |
@bactrian OCaml 4.07.1+flambda is still one of the best compilers for Coq, but I need that in-switch. If I create another Opam patch, I’ll create a new switch. |
And I suppose could also use |
oh I get it, meant to tag @avsm |
@Blaisorblade - I'm not sure you do need a secondary compiler here. The issue is that the opam binary itself was built with OCaml 4.07, which you don't need to do, presumably? |
Once you've built opam with OCaml 4.08+ you can use it to set-up whichever version of OCaml you like. It looks to me like this issue is resolved, therefore? |
No, but nevermind. |
Just for the record: ocaml-secondary-compiler would avoid the need to install another compiler for the only purpose of building opam development versions. That's the context for
|
On mac os x 10.15, opam master fails to run openssl, or sw_vers, while opam 2.0.7 works fine, and openssl and sw_vers are both available:
The error persists after make install.
The programs work.
opam config report output, as requested:
The text was updated successfully, but these errors were encountered: