Fix opam env messages #3274
Closed
Fix opam env messages #3274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dra27
force-pushed
the
fix-opam-env-message
branch
2 times, most recently
from
5987c72
to
b418f67
Compare
It should always be possible to override the shell which opam reports messages for. Add a parameter for the shell in OpamEnv.eval_string and thread that resulting parameter through the libraries. The install, pin, reinstall, remove and switch subcommands now all take the --shell parameter as a result. fixup
opam init knows what the shell is, so should use it, rather than guessing eval $(opam env).
Change in 42913bc needed to split off `csh as a separate shell.
Use $SHELL to customise the display of --help output when eval $(opam config env) is referred to. --shell is ignored (for reasons of code simplicity).
dra27
force-pushed
the
fix-opam-env-message
branch
from
b418f67
to
b4b3fca
Compare
|
Hmm, the CI golf going on here has revealed that |
|
Thanks! I am not sure about adding a |
|
Does not merge anymore, what is the status of this ? |
AltGr
added
the
PR: OUTDATED
|
This has been merged as the superior #4427! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the display of the
eval $(opam env)messages. In particular:eval `opam config env`message toeval $(opam config env). At this point, it was necessary to add a special case forcshwhich doesn't support that syntax.OpamEnv.eval_stringonly ever guessed the shell from$SHELLeven when--shellhad been passed to opam.opam initalways displayedeval $(opam env)regardless of the shell, as did--helpscreens.This PR:
`cshwhich uses backticks.OpamEnv.eval_stringto have ashellparameter. This is quite an invasive change - in particular, it means thatswitch,install,pin,removeandreinstallcommands now have a--shellparameter. I was quite haphazard about where~shellgot put... if you're happy with the idea of this change, this should be rationalised (i.e. should the argument always be named and where should it go in argument listed).opam initnow displays the correct command for the given shell.--helpscreens for theswitch,configandenvcommands now display the command based on$SHELL(i.e.OpamStd.Sys.guess_shell_compat). It's possible to peek the--shellargument here, but even I think that havingSHELL=bash opam config --shell=fish --helpwork correctly is more effort than is necessary 😉