Various bits 'n bobs #3346
Merged
Various bits 'n bobs #3346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is taken directly from ExtLib.Option Signed-off-by: David Allsopp <david.allsopp@metastack.com>
The Microsoft C compiler is also a C++ compiler (in many ways, it's the other way around...)
file:// URLs would end up with an extra slash for an empty path. Signed-off-by: David Allsopp <david.allsopp@metastack.com>
Operations permitted on OpamFilename also permitted on OpamFilename.Base Signed-off-by: David Allsopp <david.allsopp@metastack.com>
Compile the programs using an initial invocation of jbuilder so that the testsuite itself (which is still in make) can be run using --no-buffer so that results can be seen as they appear. Reduce some of the noise from the make output as well. Signed-off-by: David Allsopp <david.allsopp@metastack.com>
Also generate .gitattributes files to ensure that the shell scripts are always created with LF-endings only, even on Windows. Signed-off-by: David Allsopp <david.allsopp@metastack.com>
These configuration files need interpolated variable paths to be backslash-escaped, which means an opam-version header needs to be present in order to activate the escaping.
Issue tracked in appveyor/ci#1824
Returns the directory found, instead of the complete command. Signed-off-by: David Allsopp <david.allsopp@metastack.com>
Three fixes: - Ensure file:// URLs only use / - Use Filename.is_relative to determine an absolute path! - Ensure that concatenation maintains / on Windows Signed-off-by: David Allsopp <david.allsopp@metastack.com>
dra27
added a commit
to dra27/opam
that referenced
this pull request
May 10, 2018
This commit should be blown away before merge.
dra27
added a commit
to dra27/opam
that referenced
this pull request
May 10, 2018
dra27
added a commit
to dra27/opam
that referenced
this pull request
May 10, 2018
dra27
added a commit
to dra27/opam
that referenced
this pull request
May 10, 2018
dra27
added a commit
to dra27/opam
that referenced
this pull request
May 10, 2018
|
Thanks! |
dra27
added a commit
to dra27/opam
that referenced
this pull request
Jul 21, 2018
The sequence [m was replaced with [0m in ocaml#3346 which required an additional case in the VT-100 translator in OpamConsole. Not quite sure how that was missed...
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first chunk of #3260, separated off. Hopefully these are the non-controversial parts.