-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interleave download actions with build/install actions #3777
Conversation
I just added a commit that restores the existing behavior for "remove" after a failing "fetch": a warning gets printed, and the remove still occurs. |
Weirdly enough, this speeds up some builds for me. The reason is that |
Well, the point of the PR is to speedup the build! But it's interesting to know that it has a positive effect even without a separate queue for downloads (which would definitely make sure that downloads cannot starve builds). |
src/client/opamSolution.ml
Outdated
(* Print a warning, but still do the remove *) | ||
OpamConsole.warning | ||
"The sources of the following couldn't be obtained, they may be \ | ||
uncleanly installed:\n%s" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what you mean here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small typo :)
Thanks a lot!
After testing, one request could be to unify the output of finished downloads with that of actions:
here they don't interleave, but it would be nice for the downloads to be displayed like removals or installs, e.g. :
|
2b164ee
to
4b40a23
Compare
Caveats:
Change of behavior: in the current implementation, if a "remove" needs a "fetch" and the fetch fails, opam will print a warning but do the remove nonetheless (by just removing the files). In this PR, if the fetch fails, the remove will automatically get cancelled. In practice, this can happen only for a few packages that do not use light-uninstall, but it would be annoying nonetheless. It would probably be nice to give the user a way around this, using --force or something.This can be done in a separate PR.