Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git internal & inplace source copy #3948

Merged
merged 3 commits into from
Sep 4, 2019
Merged

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented Aug 1, 2019

This PR contains several things:

  • add a git clean on reset_tree to keep source dir clean
  • review sync_dirty on git:
    • use git to synchronize, then rsync & remove others files
    • exclude _build, _opam & vcs directories
  • When --inplace-build is given, it does a dirty synchronisation of the sources, in order to keep tracking package stats (clean, local or dirty)

src/repository/opamVCS.ml Outdated Show resolved Hide resolved
src/repository/opamVCS.ml Outdated Show resolved Hide resolved
src/repository/opamVCS.ml Outdated Show resolved Hide resolved
@AltGr
Copy link
Member

AltGr commented Aug 30, 2019

Apart from some style nitpicking, this looks good! ;)

- begin with a vcs pull then copy/remove other files
- clean _opam & _build directories
@rjbou
Copy link
Collaborator Author

rjbou commented Sep 2, 2019

Updated!

@AltGr AltGr merged commit 987b5e7 into ocaml:master Sep 4, 2019
@rjbou rjbou added this to the 2.1.0 milestone Oct 29, 2019
@rjbou rjbou mentioned this pull request Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants