Config file - opam root bump to format-version '2.1' + travis #4280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjbou
changed the title
|
Updated travis in the same time, to handle upgrade directly (from bootstrap & cache). And upgrade from 1.2 test fix, it was succeeding without doing the upgrade. |
dra27
reviewed
Jul 22, 2020
There was a problem hiding this comment.
I'd suggest baking an override into the dune files for the git-sha using a fallback rule, rather than manually editing them with sed. That change in Dune has certainly boiled my blood enough already 🙂 The src/client/no-git-version file should go in .gitignore as well.
rjbou
commented
Jul 22, 2020
Co-authored-by: David Allsopp <david.allsopp@metastack.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As new fields was added (depext ones), we need to upgrade to avoid syntax errors with an opam 2.0 bnary
fix #4266