Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update opam-format to opam-file-format new type definition #4298

Merged
merged 6 commits into from
Dec 1, 2020
Merged

Update opam-format to opam-file-format new type definition #4298

merged 6 commits into from
Dec 1, 2020

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented Aug 3, 2020 •
edited
Loading

To merge after opam-file-format new release, containing ocaml/opam-file-format#24

See details in referenced PR

@rjbou rjbou added the PR: QUEUED Pending pull request, waiting for other work to be merged or closed label Aug 5, 2020
@rjbou rjbou mentioned this pull request Aug 5, 2020
Merged
@rjbou rjbou added this to the 2.1.0~beta2 milestone Aug 26, 2020
@rjbou rjbou modified the milestones: 2.1.0~beta2, 2.1.0~beta3 Sep 14, 2020
@rjbou
Copy link
Collaborator Author

rjbou commented Oct 26, 2020

@kit-ty-kate replying to #4302 (comment) in this pr, as it is the origin.

Btw changes some API bits used in dune-release. Here is the change I had to make to dune-release to get it to work with the new API: tarides/dune-release@master...kit-ty-kate:opam-2.1
Is there a way to get some kind of backward compatible API? I feel like it might be annoying down the road for users if it ends up having a split of incompatible API.

In the opam-file-format library there is a backward compatible api, the legacy one, which is deprecated, and the new one, that can be used with Module.FullPos. cf. pr ocaml/opam-file-format#24.
In opam, it is not conceivable t have this kind of backward compatibility (maybe for OpamFile.OPAM, but even there, too much implication/duplication, need to check). But there is functions in opam-file-format that permit the translation from the old type def to the new one, cf. OpamParser.mli. They could be integrated in opam-format itself, to ease their use & visibility.

@rjbou rjbou force-pushed the endpos branch 2 times, most recently from 13c9231 to 23d56b6 Compare November 23, 2020 10:17
@rjbou rjbou merged commit 8cd1955 into ocaml:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: QUEUED Pending pull request, waiting for other work to be merged or closed
Projects
None yet
Milestone
2.1.0~beta4
Development

Successfully merging this pull request may close these issues.
1 participant
@rjbou