Parallel pin source fetching #4399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AltGr
reviewed
Oct 20, 2020
src/client/opamPinCommand.ml
Outdated
| ([],[]) fetched | ||
| in | ||
| if errored = [] | ||
| || OpamConsole.confirm "Could not retrieve%s\nContinue?" |
There was a problem hiding this comment.
We may want to be more clear about the implications of saying "yes" here ?
Also, be careful that yes is the default and may be forced with --yes misled people.
There was a problem hiding this comment.
Maybe adding something like "You may reach an inconsistent state because of those not pinned packages"?
AltGr
reviewed
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4315
Using the same example, it took 4m32 (with download-only option), and now with parallel and reuse of source dir, it takes only 1m32.
It also applies to
pin scanarguments, and url pin.cc/ @NathanReb