-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallel pin source fetching #4399
Conversation
src/client/opamPinCommand.ml
Outdated
([],[]) fetched | ||
in | ||
if errored = [] | ||
|| OpamConsole.confirm "Could not retrieve%s\nContinue?" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to be more clear about the implications of saying "yes" here ?
Also, be careful that yes
is the default and may be forced with --yes
misled people.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe adding something like "You may reach an inconsistent state because of those not pinned packages"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems all good to me, just one confirm
call that may not be clear enough to the user.
Fix #4315
Using the same example, it took 4m32 (with download-only option), and now with parallel and reuse of source dir, it takes only 1m32.
It also applies to
pin scan
arguments, and url pin.cc/ @NathanReb