Fix handling of filename-encoded pkgname in opam files #4401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that does the same thing as `libinstall`, while registering it properly in opam using `opam-custom-install`.
These are useful for handling reinstallations from e.g. `opam-custom-install`
The comment at l.2830 is now correct... See ocaml-opam/opam-publish#107
…ction it's only suitable for opam files read from repositories, and, as we could have expected, proves harmful in cases like ocaml-opam/opam-publish#107
rjbou
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was hardcoded at too low level, and not properly disabled when not
reading files from repositories.
This also exports a few more helpful functions for plugins.