-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
init: fix non-existing file check in csh #4482
Conversation
I guess the failure in appveyor is not related to my change
|
Thanks for the PR.
|
Ah thanks, I hadn't noticed the attemp to handle a non-existing file in init.(c)sh. That attempt is broken for csh, though. Line 478 in 8ce5e42
It tries to handle the error using I'll update the PR to properly check for the file existence in |
84402ad
to
f2db3e1
Compare
In csh, a failed "source" command propagates up the stack and causes all the nesting "source" commands to fail. This makes the `|| true` check useless.
f2db3e1
to
22381f1
Compare
@rjbou need anything from my side? |
Thanks! |
Oops, forgot to see the new version. lgtm, thanks @gahr! |
This fixes an issue whereas disabling the hook script by answering "no"
to the 2nd question of "opam init" you end with an init script that
tries to source the non-existing env hook script.