Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to upgrade to a hidden-version package if a hidden-version package is already installed #4525

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Allow to upgrade to a hidden-version package if a hidden-version package is already installed #4525

merged 1 commit into from
Mar 23, 2021

Conversation

kit-ty-kate
Copy link
Member

Currently if for instance ocaml-base-compiler.4.12.0~beta1 (flagged with hidden-version) is installed, calling opam upgrade` results in:

$ opam upgrade
Everything as up-to-date as possible (run with --verbose to show unavailable upgrades).

The following packages are not being upgraded because the new versions conflict with other installed packages:
  - ocaml.4.13.0
However, you may "opam upgrade" these packages explicitly, which will ask permission to downgrade or uninstall the conflicting packages.
Nothing to do.
$ opam switch invariant
["ocaml-base-compiler"]

With this patch it should be upgraded to ocaml-base-compiler.4.12.0~beta2 in this case.

cc @dra27 @AltGr

@kit-ty-kate kit-ty-kate marked this pull request as draft February 5, 2021 15:58
@kit-ty-kate kit-ty-kate marked this pull request as ready for review February 6, 2021 15:22
@kit-ty-kate
Copy link
Member Author

Successfully tested and now ready for review.

@rjbou rjbou added this to the 2.1.0~beta5 milestone Feb 12, 2021
rjbou
rjbou approved these changes Feb 12, 2021
View reviewed changes
Copy link
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just some code style comments :)

src/state/opamSwitchState.ml Outdated Show resolved Hide resolved
src/client/opamClient.ml Outdated Show resolved Hide resolved
@rjbou rjbou merged commit 5726fa8 into ocaml:master Mar 23, 2021
@rjbou
Copy link
Collaborator

rjbou commented Mar 23, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjbou rjbou rjbou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0~rc
Development

Successfully merging this pull request may close these issues.
2 participants
@kit-ty-kate @rjbou