Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and improve some depext messages #4591

Merged
merged 3 commits into from
Apr 18, 2021
Merged

Fix and improve some depext messages #4591

merged 3 commits into from
Apr 18, 2021

Conversation

AltGr
Copy link
Member

@AltGr AltGr commented Mar 8, 2021

No description provided.

dra27
dra27 reviewed Mar 8, 2021
View reviewed changes
Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can possibly make the message even clearer (although it's an advanced function!)

src/client/opamSolution.ml Outdated Show resolved Hide resolved
@rjbou rjbou added this to the 2.1.0~rc milestone Mar 8, 2021
@rjbou rjbou requested a review from dra27 March 23, 2021 13:05
@dra27
Copy link
Member

dra27 commented Mar 24, 2021

Is the message going to be updated (I'm not sure why I'm pinged for review?)

@rjbou
Copy link
Collaborator

rjbou commented Mar 24, 2021

Pinged for review according last meeting notes :)

@dra27
Copy link
Member

dra27 commented Mar 24, 2021

Ah, I must have missed the “@dra27 to look at it after @AltGr pushes changes” 🤣

dra27
dra27 approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rjbou rjbou merged commit a48acfb into ocaml:master Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjbou rjbou rjbou left review comments

@dra27 dra27 dra27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0~rc
Development

Successfully merging this pull request may close these issues.
3 participants
@AltGr @dra27 @rjbou