Speedup installation when the package has no conflict #4658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. when calling `opam install utop` on a 4.12 switch, opam spends 4s in Dose3 before calling the actual solver
|
This change would prevent all conflict messages from being printed, replacing them by "solver error": it's not a good idea as is. The other option would be to revert to what we had in 2.0: first call the external solver, then call The change was made for a reason though, so we need to examine the balance here. My impression is that the order in 2.1 is better for the user in most cases, but here again, I hadn't hit such cases where
In a perfect world we would call both in parallel :) |
AltGr
added a commit
to OCamlPro/opam
that referenced
this pull request
Oct 28, 2021
Closes ocaml#4658, see the discussion there. It'd probably be worth it to check the Dose3 check times though; they may be due to the increased complexity of the repo, but also maybe to the new dose3 version ? Also I didn't re-check the response times of the different solvers in case of complex, unsat cases : the worrying case here was mccs stalling for tenths of seconds, even sometimes timing out, while dose3 (which we would call anyway) would detect the conflict in a fraction of a second.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. when calling
opam install utopon a 4.12 switch, opam spends 4s in Dose3 before calling the actual solverPartly fixes an issue detected by @talex5 in ocurrent/docker-base-images#102 (comment)