Sandbox: Always mount every directories under / (gets rid of OPAM_USER_PATH_RO) #4795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 11, 2021
kit-ty-kate
force-pushed
the
sandbox-mount-all-rootdirs
branch
from
0e2fe8b
to
79ea94b
Compare
rjbou
approved these changes
Aug 23, 2021
AltGr
reviewed
Aug 24, 2021
No idea either but that's a fair point and I think since it was also disabled before, it's more prudent to keep it that way. Thanks! All the concerns and comments have been addressed I think. Everything should be green. |
We're not sure of the implications in terms of security so since it was disabled as well before, let's keep it that way.
rjbou
force-pushed
the
sandbox-mount-all-rootdirs
branch
from
27c1f03
to
867d89d
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative fix for #4783 and #4751.
This also helps make Linux and macOS sandbox behave the same: by default
sandbox-execmounts the whole file system (including external disks) readonly and theOPAM_USER_PATH_ROrelated code did not do anything.I don't think there is any need to restrict access to non-standard directories since it is all read-only.
This also helps users on NixOS for instance as well as people using several disks/mountpoints to host opam as highlighted by the two issues above.