-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow opam source to run without a switch, add a `--no-switch' option #4850
Conversation
295b02c
to
c799f72
Compare
c799f72
to
e6ff634
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some cosmetic suggestions but otherwise LGTM (the github "hide whitespace" option was helpful ^^)
8be5702
to
4fb7333
Compare
4fb7333
to
8f7f292
Compare
If you (@rjbou or @kit-ty-kate) think it's ready for merge, then I'm fine with it. |
@zapashcanon actually, if you have some spare time, could you add some tests to a new |
test added |
36f0ab2
to
61a17f6
Compare
61a17f6
to
5d295c7
Compare
5d295c7
to
cd2d2e4
Compare
cd2d2e4
to
e70022b
Compare
e70022b
to
b640023
Compare
@rjbou Update:
--no-switch
option fix support opam source --no-switch #4858Here's a draft to fix #4809 as asked by @dra27.
It doesn't typecheck:
But currently, there's no simple way to get a lock for the virtual state so I don't know how to fix this...
cc @AltGr @rjbou