Add 'opam pin --current' #4973
Merged
Add 'opam pin --current' #4973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjbou
reviewed
Jan 3, 2022
kit-ty-kate
approved these changes
Jan 3, 2022
There was a problem hiding this comment.
@AltGr would it be possible to use your own opam fork instead of OCamlPro’s to enable other people to rebase your PRs next time?
I’ve read through the rebased diff (master...kit-ty-kate:pin-current) and it looks good to me.
Good to merge once rebased.
|
Updated with new test |
rjbou
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to the refactoring of the orphan package handling
(bridging a gap that used to be overcome by brittle magic, allowing an
orphan package to be kept on dependent actions);
but it's an independent feature in itself, so filing this PR
independently.
Also included the reftests ports here because it's lighter than theother PR, makes more sense in the history ordering and I didn't want
to go as far as making a third PR just for the tests then waiting for
it to be merged first.
Ported in #4979