-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Order the actions listing by action/package #5045
Conversation
Repeating the logo at the beginning of each line seemed a little bit redundant, but if the header is out of the screen you won't see what action you are seing. Maybe a color bar on the left to delimit the block would help ? Also it's slightly more verbose on some simple cases, but I don't think it's harmful, e.g. https://github.com/ocaml/opam/pull/5045/files#diff-b3f6abdb5ab3eb6c5612e441c0709542022442b9cc6f47b5eae75bc5aa85799cL82 |
mmh, I'm not sure about this form. It seems more confusing to me. e.g. if the solver decides to remove everything i won't be able see it's remove instead of recompile without scrolling up quite a long way. I would much rather keep linear it as it is currently and simply reorder them |
I had a shot at doing it based on what you’re doing in this PR (thanks!). In #5041 I was more looking at something like this:
|
I agree that repeating the logo is fine/good - it means you can "locally" (i.e. on the same line) see what's going on. |
Which further means it's grep and cut & paste friendly. |
8573b8f
to
8cd78ef
Compare
Yes exactly. I think this should be kept in at the very least. |
Yes please ! (Also personally I don't need the |
Hum, Kate's version as shown above uses more hspace since it repeats the action name on each line; also see my point 1. above, it's weird to change the way the message is built without any visual clue that it has changed. |
You can omit that if you want. In general I find her design less agitated. I don't understand what your point 1 refers to. If it refers to the fact that you are changing the design and you want existing users to notice, I'm not sure that's very useful. They will just read what is offered to them and this is what has to work.
I wish people would stop making that assumption. |
Personally I'm not disturbed by that but you could try to remove it from her design and have the action names next to the label in the summary, which would then double function as a legend for the diagram. |
Yeah that was a joke. My windows are set to stack horizontally by default…
The fact that the actions were ordered topologically by dependency had some implications, which (I believe?) some may have gotten used to rely on. For example, in my screenshot above, |
6edfcd3
to
c10f902
Compare
I like that.
Aha I never got that, or more likely I did rely on it without realizing. It's true that with the new design you need to jump quite a bit around to find the root cause. Is it a good idea ? |
Can we maybe highlight the root causes ? I.e. your example: color the |
Causes are | Use of 'a list
| Required_by of 'a list
| Conflicts_with of 'a list
| Upstream_changes
| Requested
| Unavailable
| Unknown So the ones to highlight would be
I just had someone suggest attempting to print a tree instead, e.g. something like
… that could be helpful for understanding what's going on, but we probably won't want this by default (and that'll require someone interested in having fun coding it 😁 ) |
890275c
to
3d6c4d7
Compare
Rebased |
instead of by dependencies. A proposal related to ocaml#5041. Actions output: more orderly and less indented
Thanks! |
instead of by dependencies. A proposal related to #5041.