Fix environment variables value retrieval #5111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… init/setting The lazy access is problematic when an environment variable value is retrieved before it's initialisation, see OpamInitDefaults
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment variable value retrieval system uses lazy to not probe environment variables values several times. It had a side effect that, if a env var value is retrieved before init step, it is set to undefined (
None) for all other call. And it was the case forOPAMCURLandOPAMFETCHthat are used inOpamInitDefaultsto set up the default init config (and called at toplevel inOpamConfigCommand, but we can consider that it is legitimate to call it before init via the opam lib).To allow that usage, this PR adds a direct probing of the environment variable value.
fix #5108