Rebuild packages only when what is going to be installed can change #5118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
force-pushed
the
effectively_equal-modulo_state
branch
from
41455a9
to
d3c76fe
Compare
kit-ty-kate
commented
Apr 20, 2022
|
All green and ready to go |
kit-ty-kate
force-pushed
the
effectively_equal-modulo_state
branch
from
e1bff2f
to
7fc0b18
Compare
rjbou
approved these changes
Apr 27, 2022
kit-ty-kate
force-pushed
the
effectively_equal-modulo_state
branch
from
7fc0b18
to
2539238
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4647
The tests are nowhere near complete but it’s a start and it shows that #4647 (comment) discussed earlier is the only thing needed to get it working amazingly. Thanks a lot!
In this PR I’ve also fixed a bug where adding or removing the
pluginflag does not reinstall a package, which shouldn’t be the case as currently plugin creating and delation are only done during the installation and removal actions respectively.Regarding the code, I went the
?(modulo_state=false)approach instead of duplicating the function because it made thing clearer regarding what is the difference betweeneffectively_partandeffectively_part_modulo_state