opamClient: pass dl_cache from initConfig to config #5315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesm
force-pushed
the
pass-dl-cache
branch
from
ba20916
to
8fa7169
Compare
|
|
kit-ty-kate
changed the title
kit-ty-kate
approved these changes
Oct 17, 2022
rjbou
changed the title
|
We changed the title by mistake, first commit went unnoticed, which lead to the change. Can you open a different PR for making archive-mirrors modifiable? |
hannesm
force-pushed
the
pass-dl-cache
branch
from
0fc11c2
to
bc9df02
Compare
|
Hello, sorry about putting two things into a single PR. I force-pushed here (and the title reflects the change). #5321 is the other change (that previously was part of this PR). |
rjbou
approved these changes
Oct 19, 2022
rjbou
added
PR: QUEUED
rjbou
added
PR: WAITING FOR REVIEW
and removed
PR: QUEUED
|
Added a test for opamrc handling |
|
Thanks @rjbou, to me this looks ready to be merged. |
kit-ty-kate
approved these changes
Oct 24, 2022
|
thanks! |
5 tasks
Merged
kit-ty-kate
pushed a commit
to kit-ty-kate/opam
that referenced
this pull request
Feb 17, 2023
opamClient: pass dl_cache from initConfig to config
rjbou
added a commit
to kit-ty-kate/opam
that referenced
this pull request
May 12, 2023
opamClient: pass dl_cache from initConfig to config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the dl_cache from the InitConfig was never used.