configure: Ensure a complementary (32bit on 64bit platforms and 64bit on 32bit platforms) C compiler is installed on Windows #5522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kit-ty-kate
force-pushed
the
fix-mingw
branch
2 times, most recently
from
b7b2aa7
to
c22b3e2
Compare
kit-ty-kate
changed the title
… on 32bit platforms) C compiler is installed on Windows
|
Having a warning makes more difficult to debug, see #5601 |
rjbou
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/stubs/win32/cc64was never written before because the C compiler was always the wrong one (x86_32 when only the x86_64 is available and x86_64 when only the x86_32 one is available)I'm not sure how it ever worked before. Maybe the typical setup always has both x86_64 and x86_32 so it somehow worked out.A complementary C compiler (32bit on 64bit platforms and 64bit on 32bit platforms) is required to build opam-putenv on Windows, but the check for those compilers only output a warning instead of an error. Said warning made it seem like it way an optional binary, however this is not the case and is always required on Windows AFAIK.
cc @MisterDA