opam lint: Allow to mark a set of warnings as errors #5652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjbou
force-pushed
the
lint-warn-error
branch
from
c7e4168
to
62e0cb2
Compare
rjbou
approved these changes
Sep 8, 2023
|
I've added a test for --warn option (to complete ?) and a commit that adds the change in display (warning -> error). |
kit-ty-kate
force-pushed
the
lint-warn-error
branch
from
62e0cb2
to
218448c
Compare
rjbou
reviewed
Sep 11, 2023
Co-authored-by: R. Boujbel <rjbou@ocamlpro.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5651
This PR allows to mark a set of warnings as error and make the command fail.
Examples:
opam lint -W@0..999enables all warnings and errors and fail if any is detected.opam lint -W@62enables W62 and fail if this warning is detected but ignore any other warnings or errorsThe syntax is inspired from the
ocamlc -woption.