Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shell integration: properly handle filenames starting with tilde #5803

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Shell integration: properly handle filenames starting with tilde #5803

wants to merge 2 commits into from

Conversation

ElectreAAS
Copy link
Collaborator

Fixes #5801.

@kit-ty-kate
Copy link
Member

kit-ty-kate commented Jan 24, 2024 •
edited
Loading

One thing that the original code did and the new code doesn’t do is if you just type .bashrc for example, it used to default to $HOME/.bashrc instead of $PWD/.bashrc.

I personally prefer the code without such magic (your version) but it’s one thing to keep in mind. That behaviour has only been there since opam 2.2.0~alpha1 and up for now so it’s not a big deal to change its behaviour.

@kit-ty-kate kit-ty-kate mentioned this pull request Feb 5, 2024
Open
@ElectreAAS ElectreAAS mentioned this pull request Feb 5, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Double tilde when manually entering filename for shell configuration
2 participants
@ElectreAAS @kit-ty-kate