-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix opam tree --test --doc assigning the with-{test,doc} variables to unrequested packages #5919
Merged
kit-ty-kate
merged 4 commits into
ocaml:master
from
kit-ty-kate:fix-wrong-var-assign-tree
May 7, 2024
Merged
Fix opam tree --test --doc assigning the with-{test,doc} variables to unrequested packages #5919
kit-ty-kate
merged 4 commits into
ocaml:master
from
kit-ty-kate:fix-wrong-var-assign-tree
May 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ab70c2a
to
cda67cb
Compare
rjbou
reviewed
May 3, 2024
b1b779d
to
3e2f531
Compare
3e2f531
to
f7b1754
Compare
…bles in their dependencies (second level)
25d2e22
to
3781f29
Compare
rjbou
reviewed
May 3, 2024
36cd052
to
dc707b5
Compare
All cleaned up, squashed and ready to go. |
…ted packages Co-authored-by: Raja Boujbel <raja.boujbel@ocamlpro.com>
And more generally for simulated states, when packages need to be installed Co-authored-by: Raja Boujbel <raja.boujbel@ocamlpro.com>
dc707b5
to
0973989
Compare
rjbou
approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5755
Fix #5920
OpamSwitchState.universe
was called with~requested:st.installed
so all the packages that were currently installed had theirwith-doc
,with-test
,with-dev-setup
anddev
variables assigned instead of just the packages that were given as input to theopam tree
command.TODO:add a test (seeopam tree
causes error when used with--with-doc
#5755 (comment))