Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opam tree --test --doc assigning the with-{test,doc} variables to unrequested packages #5919

Merged
merged 4 commits into from
May 7, 2024

Conversation

kit-ty-kate
Copy link
Member

@kit-ty-kate kit-ty-kate commented Apr 10, 2024

Fix #5755
Fix #5920

OpamSwitchState.universe was called with ~requested:st.installed so all the packages that were currently installed had their with-doc, with-test, with-dev-setup and dev variables assigned instead of just the packages that were given as input to the opam tree command.

TODO:

src/client/opamTreeCommand.ml Outdated Show resolved Hide resolved
@kit-ty-kate kit-ty-kate changed the title Fix opam tree --tree --doc assigning the with-{test,doc} variables to unrequested packages Fix opam tree --test --doc assigning the with-{test,doc} variables to unrequested packages May 3, 2024
@rjbou rjbou force-pushed the fix-wrong-var-assign-tree branch from 25d2e22 to 3781f29 Compare May 3, 2024 17:37
src/client/opamTreeCommand.ml Outdated Show resolved Hide resolved
src/client/opamTreeCommand.ml Outdated Show resolved Hide resolved
@kit-ty-kate
Copy link
Member Author

All cleaned up, squashed and ready to go.

@kit-ty-kate kit-ty-kate requested a review from rjbou May 7, 2024 13:26
kit-ty-kate and others added 2 commits May 7, 2024 19:55
…ted packages

Co-authored-by: Raja Boujbel <raja.boujbel@ocamlpro.com>
And more generally for simulated states, when packages need to be installed

Co-authored-by: Raja Boujbel <raja.boujbel@ocamlpro.com>
@rjbou rjbou force-pushed the fix-wrong-var-assign-tree branch from dc707b5 to 0973989 Compare May 7, 2024 17:59
Copy link
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@kit-ty-kate kit-ty-kate merged commit 3159a67 into ocaml:master May 7, 2024
29 checks passed
@kit-ty-kate kit-ty-kate deleted the fix-wrong-var-assign-tree branch May 7, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants