Restore signature of OpamStateConfig.opamroot #6047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5457 changed the signature of
OpamStateConfig.opamrootbetween beta2 and beta3 which has broken the opam-dune-lint plugin along with a few other packages. This seems a shame, given that it's quite trivial and indeed natural to have two functions and simply have the provenance-returning version have a new name.Given that
it looks like we'll need an rc2 to deal with the Cygwin hangit's a demonstrably safe internal API restoration, I'm hoping we can slip this API change inat the same timeto the final release. If we do, ocaml/opam-repository#26066 can be reverted.Backported into 2.2 in #6058