Allowing packages to override default environment updates #6051
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this is as a draft PR so it doesn't get forgotten. This has come up in the context of ocaml/opam-repository#25928.
The problem is that it is not possible for a package to prepend a directory before opam's
bin
directory in PATH and this feels like a mistake. Given, say,/usr/local/bin:/usr/bin:/bin
etc. in a standard posix PATH, it feels reasonable that opam prepends the switchbin
directory before packages - i.e. we have<package-PATH-directory>:<switch-PATH-directory>:/usr/local/bin:/usr/bin:/bin
. This is also mildly more coherent with other environment variable updates in build-env, which the manual explicitly states can be overridden.In the context of the opam-repository PR above, it means that
doesn't allow binaries in the additional directory to override those in the switch directory, which seems incorrect.