Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depext: fix Debian/apt lookup for installed packages #6054

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented Jun 25, 2024

dpkg-query output have the information in the first column, but only the second character needed to be looked up.

Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd possibly expand the comment to be more explicit that we're ignoring the first character (and why), but it was very easy to answer that from the dpkg-query man page!

master_changes.md Outdated Show resolved Hide resolved
src/state/opamSysInteract.ml Show resolved Hide resolved
@kit-ty-kate
Copy link
Member

Queued on #6063 for CI to succeed

@kit-ty-kate kit-ty-kate added PR: QUEUED Pending pull request, waiting for other work to be merged or closed and removed STATE: READY TO MERGE labels Jul 2, 2024
dpkg-query output have the information in the first column, but only the
second character needed to be looked up.
@rjbou rjbou removed the PR: QUEUED Pending pull request, waiting for other work to be merged or closed label Jul 10, 2024
@rjbou rjbou merged commit 95f6b9d into ocaml:master Jul 10, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants