Make "opam install --check" check if all dependencies are installed recursively #6122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
added
KIND: BUG
PR: QUEUED
kit-ty-kate
force-pushed
the
install-check-recursive
branch
from
c5b2bf6
to
efa4c0b
Compare
rjbou
force-pushed
the
install-check-recursive
branch
from
efa4c0b
to
f98490d
Compare
rjbou
reviewed
Aug 2, 2024
Comment on lines
+52
to
+194
| ### opam install --fake a.3 | ||
| The following actions will be faked: | ||
| === upgrade 1 package | ||
| - upgrade a 1 to 3 | ||
| === install 1 package | ||
| - install b 1 [required by a] | ||
|
|
||
| <><> Processing actions <><><><><><><><><><><><><><><><><><><><><><><><><><><><> | ||
| Faking installation of b.1 | ||
| Faking installation of a.3 | ||
| Done. |
There was a problem hiding this comment.
Out of curiosity, why faking the install ?
There was a problem hiding this comment.
no other reason other than the force of habit and just in case it makes it faster
kit-ty-kate
force-pushed
the
install-check-recursive
branch
from
f98490d
to
56e4dc0
Compare
kit-ty-kate
removed
the
PR: QUEUED
kit-ty-kate
force-pushed
the
install-check-recursive
branch
from
56e4dc0
to
4e1df98
Compare
|
The benchmark failure is real and is caused by an infinit loop. I'll have a look |
kit-ty-kate
force-pushed
the
install-check-recursive
branch
from
75abbf1
to
868fad4
Compare
rjbou
reviewed
Aug 20, 2024
kit-ty-kate
force-pushed
the
install-check-recursive
branch
from
868fad4
to
e498c5f
Compare
rjbou
force-pushed
the
install-check-recursive
branch
from
e498c5f
to
d3dd124
Compare
rjbou
approved these changes
Aug 20, 2024
rjbou
reviewed
Aug 20, 2024
|
|
||
| let assume_built_restrictions ?available_packages t atoms = | ||
| let missing = check_installed ~build:false ~post:false t atoms in | ||
| let missing = | ||
| check_installed ~build:false ~post:false ~recursive:false t atoms |
There was a problem hiding this comment.
Assume built does not check recursively, is it to not change the known behaviour?
There was a problem hiding this comment.
no, the previous behaviour of this function did not check recursively so the behaviour of assume-built hasn't changed either
rjbou
force-pushed
the
install-check-recursive
branch
from
d3dd124
to
cdb37b1
Compare
…s dependencies recursively
…ons and post-dependencies
…availibility checking
…_constraint and atom
kit-ty-kate
force-pushed
the
install-check-recursive
branch
from
c67555b
to
b930ba8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6097
Queued on top of #6121
Queued on #6123