Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tuareg: use #'; don't mark (tuareg-opam-update-env) as obsolete & docs: Update README.md #308

Closed
wants to merge 2 commits into from

Conversation

erikmd
Copy link
Contributor

@erikmd erikmd commented Jul 18, 2023

This makes it possible to:

  • keep the "C-c C-w" key-binding within tuareg
  • don't trigger a fatal warning at byte-comp because of that
  • see opam-switch-mode as a recommended, albeit optional dependency

This makes it possible to:

* keep the "C-c C-w" key-binding within tuareg
* don't trigger a fatal warning at byte-comp because of that
* see `opam-switch-mode` as a recommended, albeit optional dependency
@erikmd erikmd changed the title fix: tuareg: use #'; don't mark (tuareg-opam-update-env) as obsolete fix: tuareg: use #'; don't mark (tuareg-opam-update-env) as obsolete & docs: Update README.md Jul 18, 2023
@erikmd
Copy link
Contributor Author

erikmd commented Jul 18, 2023

FYI I took the opportunity to document opam-switch-mode in the README (there is a dedicated section for other modes):

https://github.com/ocaml/tuareg/blob/ac5428e651f994b3f1a171e2b08ee9f8e835c97b/README.md#opam-switch-mode

( Sorry, I could have done this in my earlier PR #307 )

@monnier
Copy link
Contributor

monnier commented Jul 18, 2023 via email

@erikmd
Copy link
Contributor Author

erikmd commented Jul 18, 2023

@monnier

Merci Erik,

👍 de même, merci pour le cherry-pick.

Now closing the PR.

@erikmd erikmd closed this Jul 18, 2023
@erikmd erikmd deleted the fix-detail branch July 18, 2023 22:30
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants