Skip to content

Commit

Permalink
updating cran comments
Browse files Browse the repository at this point in the history
  • Loading branch information
osorensen committed Jan 22, 2024
1 parent d5deac9 commit c962d47
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
## Resubmission Note

UPDATE: The original resubmission did not fix a valgrind error. We have reproduced the error and fixed it.

This is a resubmission, fixing issues with "clang-UBSAN", "gcc-UBSAN", and "valgrind". We have reproduced the errors using the Docker images rocker/r-devel-san, and made the necessary changes.

There are also two failing unit tests on noLD. We believe these to be cause be differences in floating point numbers, since the test expectations are based on values after running thousands of steps of an MCMC algorithm. We have added testthat::skip_on_cran() to the two tests in question.
Expand Down

0 comments on commit c962d47

Please sign in to comment.